Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cypress Test Suite for Facility Notice Board Functionality Verification #9045
Add Cypress Test Suite for Facility Notice Board Functionality Verification #9045
Changes from 3 commits
66d6ef41566910dd38cef76dac1edb8c5eccbe768d9a1ad6cd3d2034e6970b773d44a1b800349c2069bf28d43b087196e31d187b2b7bed314c84e13ec37084f196fbe958f148f0307490fb706c7fa0842e076c3e461dc919f8044807b9d8b0690862c306fce93924c6edc48d21ff02f8File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Enhance class structure with TypeScript best practices.
Add type definitions and constants to improve maintainability and type safety.
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Improve UI interaction reliability.
Add proper error handling, timeouts, and assertions for UI interactions.
fillNotifyText(message: string): void { - cy.get("#NotifyModalMessageInput").should("be.visible").type(message); + cy.get(this.SELECTORS.NOTIFY_INPUT, { timeout: 10000 }) + .should('be.visible') + .should('be.enabled') + .clear() + .type(message, { delay: 100 }) + .should('have.value', message); } openNotificationSlide(): void { - cy.get("#notification-slide-btn").should("be.visible").click(); + cy.get(this.SELECTORS.NOTIFICATION_SLIDE_BTN, { timeout: 10000 }) + .should('be.visible') + .should('be.enabled') + .click() + .should('not.be.enabled'); } closeNotificationSlide(): void { - cy.get("#close-slide-over").should("be.visible").click(); + cy.get(this.SELECTORS.CLOSE_SLIDE_BTN, { timeout: 10000 }) + .should('be.visible') + .should('be.enabled') + .click() + .should('not.exist'); } visitNoticeBoard(): void { - cy.get("a[href='/notice_board']").should("be.visible").click(); + cy.get(this.SELECTORS.NOTICE_BOARD_LINK, { timeout: 10000 }) + .should('be.visible') + .should('not.be.disabled') + .click(); }Also applies to: 6-8, 10-12, 14-16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add timeout and error handling for link interaction.
The notice board link interaction could be more robust with proper timeout and error handling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Enhance API interception and verification.
Add proper response validation, error handling, and use API path constants.
interceptFacilitySearchReq(): void { - cy.intercept("GET", "**/api/v1/facility/**").as("searchFacility"); + cy.intercept("GET", `${this.API_PATHS.FACILITY}/**`).as("searchFacility"); } verifyFacilitySearchReq(): void { - cy.wait("@searchFacility").its("response.statusCode").should("eq", 200); + cy.wait("@searchFacility").then((interception) => { + if (!interception.response) { + throw new Error('No response received from facility search'); + } + expect(interception.response.statusCode).to.equal(200); + expect(interception.response.body).to.have.property('data'); + }); } interceptPostNotificationReq(): void { - cy.intercept("POST", "**/api/v1/notification/notify").as("notifyFacility"); + cy.intercept("POST", `${this.API_PATHS.NOTIFICATION}/notify`).as("notifyFacility"); } verifyPostNotificationReq(): void { - cy.wait("@notifyFacility").its("response.statusCode").should("eq", 204); + cy.wait("@notifyFacility").then((interception) => { + if (!interception.response) { + throw new Error('No response received from notification post'); + } + expect(interception.request.body).to.have.property('message'); + expect(interception.response.statusCode).to.equal(204); + }); } interceptGetNotificationReq(): void { - cy.intercept("GET", "**/api/v1/notification/**").as("getNotifications"); + cy.intercept("GET", `${this.API_PATHS.NOTIFICATION}/**`).as("getNotifications"); } verifyGetNotificationReq(): void { - cy.wait("@getNotifications").its("response.statusCode").should("eq", 200); + cy.wait("@getNotifications").then((interception) => { + if (!interception.response) { + throw new Error('No response received from get notifications'); + } + const response = interception.response; + expect(response.statusCode).to.equal(200); + + const body = response.body as NotificationResponse; + expect(body).to.have.property('message'); + expect(body).to.have.property('status'); + }); }Also applies to: 29-35, 37-43
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add error handling for notification POST requests.
The notification POST verification should handle error cases and validate request payload.
interceptPostNotificationReq(): void { - cy.intercept("POST", "**/api/v1/notification/notify").as("notifyFacility"); + cy.intercept("POST", this.API_PATHS.NOTIFICATION + '/notify').as("notifyFacility"); } verifyPostNotificationReq(): void { - cy.wait("@notifyFacility").its("response.statusCode").should("eq", 204); + cy.wait("@notifyFacility").then((interception) => { + // Verify request payload + expect(interception.request.body).to.have.property('message'); + // Verify response + expect(interception.response?.statusCode).to.equal(204); + // Handle potential error responses + if (interception.response?.statusCode !== 204) { + throw new Error(`Notification failed: ${interception.response?.body}`); + } + }); }There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Enhance GET notification verification.
Add proper response validation for the get notifications endpoint.
interceptGetNotificationReq(): void { - cy.intercept("GET", "**/api/v1/notification/**").as("getNotifications"); + cy.intercept("GET", `${this.API_PATHS.NOTIFICATION}/**`).as("getNotifications"); } verifyGetNotificationReq(): void { - cy.wait("@getNotifications").its("response.statusCode").should("eq", 200); + cy.wait("@getNotifications").then((interception) => { + const response = interception.response; + expect(response?.statusCode).to.equal(200); + + const body = response?.body as NotificationResponse; + expect(body).to.have.property('message'); + expect(body).to.have.property('status'); + }); }