Add Cypress Test Suite for Sample Test Request Workflow #8977
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,8 +34,8 @@ describe("Patient Discharge based on multiple reason", () => { | |
| patientPage.visitPatient("Dummy Patient 12"); | ||
| patientDischarge.clickDischarge(); | ||
| patientDischarge.selectDischargeReason(patientDischargeReason4); | ||
| cy.clickSubmitButton("Confirm Discharge"); | ||
| cy.clickSubmitButton("Acknowledge & Submit"); | ||
|
Comment on lines
+37
to
+38
There was a problem hiding this comment. 🛠️ Refactor suggestion Add assertions between consecutive button clicks Multiple consecutive button clicks without intermediate assertions or waits could lead to flaky tests if the UI hasn't finished processing the first action. Consider adding appropriate assertions or waits: cy.clickSubmitButton("Confirm Discharge");
+cy.get('.discharge-confirmation-dialog').should('be.visible');
cy.clickSubmitButton("Acknowledge & Submit");
|
||
| cy.verifyNotification("Patient Discharged Successfully"); | ||
| cy.closeNotification(); | ||
| // Verify the consultation dashboard reflection | ||
|
|
@@ -52,8 +52,8 @@ describe("Patient Discharge based on multiple reason", () => { | |
| patientDischarge.selectDischargeReason(patientDischargeReason3); | ||
| patientDischarge.typeDischargeNote(patientDeathCause); | ||
| patientDischarge.typeDoctorName(doctorName); | ||
| cy.clickSubmitButton("Confirm Discharge"); | ||
| cy.clickSubmitButton("Acknowledge & Submit"); | ||
| cy.verifyNotification("Patient Discharged Successfully"); | ||
| cy.closeNotification(); | ||
| // Verify the consultation dashboard reflection | ||
|
|
@@ -77,8 +77,8 @@ describe("Patient Discharge based on multiple reason", () => { | |
| // select a non-registered facility and perform the discharge | ||
| patientDischarge.typeReferringFacility(referringFreetextFacility); | ||
| cy.wait(2000); | ||
| cy.clickSubmitButton("Confirm Discharge"); | ||
| cy.clickSubmitButton("Acknowledge & Submit"); | ||
| cy.wait(2000); | ||
| cy.verifyNotification("Patient Discharged Successfully"); | ||
|
Comment on lines
+80
to
83
There was a problem hiding this comment. 🛠️ Refactor suggestion Replace arbitrary waits with proper assertions Using fixed timeouts ( Consider replacing the waits with assertions: -cy.wait(2000);
cy.clickSubmitButton("Confirm Discharge");
+cy.get('.discharge-confirmation-dialog').should('be.visible');
cy.clickSubmitButton("Acknowledge & Submit");
-cy.wait(2000);
+cy.get('.notification-toast').should('be.visible');
cy.verifyNotification("Patient Discharged Successfully");
|
||
| cy.closeNotification(); | ||
|
|
@@ -104,13 +104,13 @@ describe("Patient Discharge based on multiple reason", () => { | |
| patientPrescription.selectMedicine(patientMedicine); | ||
| patientPrescription.enterDosage("4"); | ||
| patientPrescription.selectDosageFrequency("Twice daily"); | ||
| cy.clickSubmitButton("Submit"); | ||
| cy.verifyNotification("Medicine prescribed"); | ||
| cy.wait(2000); | ||
| cy.closeNotification(); | ||
| // submit the discharge pop-up | ||
| cy.clickSubmitButton("Confirm Discharge"); | ||
| cy.clickSubmitButton("Acknowledge & Submit"); | ||
| cy.wait(2000); | ||
| cy.verifyNotification("Patient Discharged Successfully"); | ||
|
Comment on lines
+107
to
115
There was a problem hiding this comment. 🛠️ Refactor suggestion Improve test reliability and reusability Two suggestions for improvement:
Example implementation: // In commands.ts
Cypress.Commands.add('prescribeMedicine', (medicine: string, dosage: string, frequency: string) => {
cy.get('[data-cy=add-prescription]').click();
cy.interceptMedibase();
cy.get('[data-cy=medicine-box]').click();
cy.get(`[data-cy=medicine-${medicine}]`).click();
cy.get('[data-cy=dosage-input]').type(dosage);
cy.get('[data-cy=frequency-select]').select(frequency);
cy.clickSubmitButton('Submit');
cy.get('.notification-toast').should('be.visible')
.and('contain', 'Medicine prescribed');
});
// In test
cy.prescribeMedicine(patientMedicine, "4", "Twice daily");This would make the test more maintainable and reusable across different test files. |
||
| cy.closeNotification(); | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,7 +28,7 @@ describe("Patient Investigation Creation from Patient consultation page", () => | |
| "Haematology", | ||
| "Urine Test", | ||
| ]); | ||
| cy.clickSubmitButton("Save Investigation"); | ||
| cy.verifyNotification("Please Enter at least one value"); | ||
| cy.closeNotification(); | ||
| // Temporary workflow for investigation since we dont have dummy data and moving away from existing module | ||
|
Comment on lines
+31
to
34
There was a problem hiding this comment. 🛠️ Refactor suggestion Add comprehensive test coverage for investigation workflow. The current test implementation appears incomplete, as indicated by the comment. Consider enhancing the test coverage:
Here's a suggested enhancement: cy.clickSubmitButton("Save Investigation");
cy.verifyNotification("Please Enter at least one value");
cy.closeNotification();
-// Temporary workflow for investigation since we dont have dummy data and moving away from existing module
+// Add investigation values
+patientInvestigation.fillInvestigationValues({
+ haematology: { value: "12.5", unit: "g/dL" },
+ urineTest: { value: "Normal", unit: "N/A" }
+});
+
+// Submit and verify
+cy.clickSubmitButton("Save Investigation");
+cy.verifyNotification("Investigation saved successfully");
+
+// Verify investigation details
+patientInvestigation.verifyInvestigationDetails({
+ type: ["Haematology", "Urine Test"],
+ status: "Completed"
+});
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -55,7 +55,7 @@ describe("Patient Log Update in Normal, Critical and TeleIcu", () => { | |
| patientPage.visitPatient(domicilaryPatient); | ||
| patientConsultationPage.clickEditConsultationButton(); | ||
| patientConsultationPage.selectPatientSuggestion("Domiciliary Care"); | ||
| cy.clickSubmitButton("Update Consultation"); | ||
| cy.verifyNotification("Consultation updated successfully"); | ||
| cy.closeNotification(); | ||
| patientLogupdate.clickLogupdate(); | ||
|
|
@@ -74,7 +74,7 @@ describe("Patient Log Update in Normal, Critical and TeleIcu", () => { | |
| patientLogupdate.selectRhythm(patientRhythmType); | ||
| patientLogupdate.typeRhythm(patientRhythm); | ||
| cy.get("#consciousness_level-option-RESPONDS_TO_PAIN").click(); | ||
| cy.clickSubmitButton("Save"); | ||
| cy.verifyNotification("Tele-medicine Log created successfully"); | ||
| }); | ||
|
|
||
|
|
@@ -108,25 +108,25 @@ describe("Patient Log Update in Normal, Critical and TeleIcu", () => { | |
| patientPrescription.selectMedicine("DOLO"); | ||
| patientPrescription.enterDosage("4"); | ||
| patientPrescription.selectDosageFrequency("Twice daily"); | ||
| cy.clickSubmitButton("Submit"); | ||
| cy.verifyNotification("Medicine prescribed"); | ||
| cy.closeNotification(); | ||
| // Submit the doctors log update | ||
| cy.clickSubmitButton("Save and Continue"); | ||
| cy.wait(2000); | ||
|
Comment on lines
+111
to
116
There was a problem hiding this comment. Replace arbitrary wait with proper assertions The test uses Improve the test stability: cy.clickSubmitButton("Submit");
+ cy.intercept('POST', '**/api/v1/prescriptions').as('createPrescription');
+ cy.intercept('POST', '**/api/v1/progress_notes').as('createProgressNote');
cy.verifyNotification("Medicine prescribed");
cy.closeNotification();
cy.clickSubmitButton("Save and Continue");
- cy.wait(2000);
+ cy.wait('@createProgressNote').its('response.statusCode').should('eq', 201);
cy.verifyNotification("Progress Note created successfully");
|
||
| cy.verifyNotification("Progress Note created successfully"); | ||
| cy.closeNotification(); | ||
| // modify the relevant critical care log update | ||
| patientLogupdate.selectCriticalCareSection("Neurological Monitoring"); | ||
| cy.get("#consciousness_level-option-RESPONDS_TO_PAIN").click(); | ||
| cy.get("#left_pupil_light_reaction-option-FIXED").click(); | ||
| cy.clickSubmitButton("Update Details"); | ||
| cy.verifyNotification( | ||
| "Neurological Monitoring details succesfully updated.", | ||
| ); | ||
| cy.closeNotification(); | ||
| // Final Submission of the form | ||
| cy.clickSubmitButton("Complete"); | ||
| cy.verifyNotification("Progress Note Log Update filed successfully"); | ||
| cy.closeNotification(); | ||
| // Verify the data reflection | ||
|
|
@@ -143,7 +143,7 @@ describe("Patient Log Update in Normal, Critical and TeleIcu", () => { | |
| patientLogupdate.clickUpdateDetail(); | ||
| patientLogupdate.typeSystolic(patientModifiedSystolic); | ||
| patientLogupdate.typeDiastolic(patientModifiedDiastolic); | ||
| cy.clickSubmitButton("Continue"); | ||
| cy.verifyNotification("Progress Note updated successfully"); | ||
| }); | ||
|
|
||
|
|
@@ -156,7 +156,7 @@ describe("Patient Log Update in Normal, Critical and TeleIcu", () => { | |
| patientLogupdate.clickLogupdate(); | ||
| patientLogupdate.selectRoundType("Detailed Update"); | ||
| patientLogupdate.selectPatientCategory(patientCategory); | ||
| cy.clickSubmitButton("Save and Continue"); | ||
| cy.verifyNotification("Detailed Update created successfully"); | ||
| cy.closeNotification(); | ||
| // Select two Section - First One is Respiratory Support | ||
|
|
@@ -166,18 +166,18 @@ describe("Patient Log Update in Normal, Critical and TeleIcu", () => { | |
| patientLogupdate.selectOxygenSupport(); | ||
| patientLogupdate.typeOxygenFlowRate(patientOxygenFlowRate); | ||
| patientLogupdate.typeVentilatorSpo2(patientSpo2); | ||
| cy.clickSubmitButton("Update Details"); | ||
| cy.verifyNotification("Respiratory Support details succesfully updated."); | ||
| cy.closeNotification(); | ||
| // Second Section will be Blood Sugar | ||
| patientLogupdate.selectCriticalCareSection("Blood Sugar"); | ||
| patientLogupdate.typeBloodSugar(patientBloodSugar); | ||
| patientLogupdate.typeInsulinDosage(patientInsulinDosage); | ||
| cy.get("#insulin_intake_frequency-option-BD").click(); | ||
| cy.clickSubmitButton("Update Details"); | ||
| cy.verifyNotification("Blood Sugar details succesfully updated."); | ||
| // Submit the form and verify the details | ||
| cy.clickSubmitButton("Complete"); | ||
| cy.verifyNotification("Detailed Log Update filed successfully"); | ||
| cy.closeNotification(); | ||
| cy.contains("button", "Log Updates").click(); | ||
|
|
@@ -203,10 +203,10 @@ describe("Patient Log Update in Normal, Critical and TeleIcu", () => { | |
| patientLogupdate.selectCriticalCareSection("Dialysis"); | ||
| patientLogupdate.typeFluidBalance(patientFluidBalance); | ||
| patientLogupdate.typeNetBalance(patientNetBalance); | ||
| cy.clickSubmitButton("Update Details"); | ||
| cy.verifyNotification("Dialysis details succesfully updated."); | ||
| cy.closeNotification(); | ||
| cy.clickSubmitButton("Complete"); | ||
| cy.verifyNotification("Detailed Log Update filed successfully"); | ||
| cy.closeNotification(); | ||
| //Reverify the editted and newly added data | ||
|
|
@@ -251,7 +251,7 @@ describe("Patient Log Update in Normal, Critical and TeleIcu", () => { | |
| patientLogupdate.selectRhythm(patientRhythmType); | ||
| patientLogupdate.typeRhythm(patientRhythm); | ||
| cy.get("#consciousness_level-option-RESPONDS_TO_PAIN").click(); | ||
| cy.clickSubmitButton("Save"); | ||
| cy.wait(2000); | ||
| cy.verifyNotification("Brief Update created successfully"); | ||
| // Verify the card content | ||
|
|
@@ -263,7 +263,7 @@ describe("Patient Log Update in Normal, Critical and TeleIcu", () => { | |
| patientPage.visitPatient(domicilaryPatient); | ||
| patientConsultationPage.clickEditConsultationButton(); | ||
| patientConsultationPage.selectPatientSuggestion("Domiciliary Care"); | ||
| cy.clickSubmitButton("Update Consultation"); | ||
| cy.verifyNotification("Consultation updated successfully"); | ||
| cy.closeNotification(); | ||
| patientLogupdate.clickLogupdate(); | ||
|
|
@@ -281,7 +281,7 @@ describe("Patient Log Update in Normal, Critical and TeleIcu", () => { | |
| patientLogupdate.selectRhythm(patientRhythmType); | ||
| patientLogupdate.typeRhythm(patientRhythm); | ||
| cy.get("#consciousness_level-option-RESPONDS_TO_PAIN").click(); | ||
| cy.clickSubmitButton("Save"); | ||
| cy.verifyNotification("Brief Update created successfully"); | ||
| cy.closeNotification(); | ||
| // edit the card and verify the data. | ||
|
|
@@ -307,7 +307,7 @@ describe("Patient Log Update in Normal, Critical and TeleIcu", () => { | |
| patientLogupdate.typeSystolic(patientModifiedSystolic); | ||
| patientLogupdate.clearIntoElementById("#diastolic"); | ||
| patientLogupdate.typeDiastolic(patientModifiedDiastolic); | ||
| cy.clickSubmitButton("Continue"); | ||
| cy.verifyNotification("Brief Update updated successfully"); | ||
| cy.contains("button", "Log Updates").click(); | ||
| patientLogupdate.clickLogUpdateViewDetails( | ||
|
|
@@ -324,7 +324,7 @@ describe("Patient Log Update in Normal, Critical and TeleIcu", () => { | |
| patientPage.visitPatient(domicilaryPatient); | ||
| patientConsultationPage.clickEditConsultationButton(); | ||
| patientConsultationPage.selectPatientSuggestion("Domiciliary Care"); | ||
| cy.clickSubmitButton("Update Consultation"); | ||
| cy.verifyNotification("Consultation updated successfully"); | ||
| cy.closeNotification(); | ||
| patientLogupdate.clickLogupdate(); | ||
|
|
@@ -336,7 +336,7 @@ describe("Patient Log Update in Normal, Critical and TeleIcu", () => { | |
| patientLogupdate.typeTemperature(patientTemperature); | ||
| patientLogupdate.typeRespiratory(patientRespiratory); | ||
| cy.get("#consciousness_level-option-RESPONDS_TO_PAIN").click(); | ||
| cy.clickSubmitButton("Save"); | ||
| cy.verifyNotification("Brief Update created successfully"); | ||
| cy.closeNotification(); | ||
| cy.verifyContentPresence("#consultation-buttons", ["9"]); | ||
|
|
@@ -346,7 +346,7 @@ describe("Patient Log Update in Normal, Critical and TeleIcu", () => { | |
| patientLogupdate.typeSystolic(patientSystolic); | ||
| patientLogupdate.typeDiastolic(patientDiastolic); | ||
| patientLogupdate.typePulse(patientPulse); | ||
| cy.clickSubmitButton("Save"); | ||
| cy.verifyNotification("Brief Update created successfully"); | ||
| cy.closeNotification(); | ||
| cy.verifyContentPresence("#consultation-buttons", ["-"]); | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Replace hard-coded wait with proper assertion
Using
cy.wait(2000)is an anti-pattern in Cypress. Instead, wait for the API response or UI state change.cy.clickSubmitButton("Submit"); -cy.wait(2000); +cy.intercept('POST', '**/prescriptions').as('prescriptionSubmit'); +cy.wait('@prescriptionSubmit'); cy.verifyNotification("Medicine prescribed");