Added avatars to userlist and userAutoComplete #8903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rithviknishad
requested changes
Oct 23, 2024
… issues/ohcnetwork#8869/user-avatat-in-user-autocomplete-and-user-list
|
Done! |
|
Why is Cypress test failing? Is there anything that needs to be done from my end? |
rithviknishad
approved these changes
Oct 23, 2024
bodhish
requested changes
Oct 23, 2024
| @@ -21311,4 +21311,4 @@ | |||
| } | |||
| } | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Unrelated change, do we need this 🤔
| @@ -80,8 +80,11 @@ export default function UserAutocomplete(props: UserSearchProps) { | |||
| )} | |||
| optionLabel={formatName} | |||
| optionIcon={userOnlineDot} | |||
| optionImage={(option: UserBareMinimum) => | |||
| option.read_profile_picture_url || "" | |||
There was a problem hiding this comment.
why should we cast it to an empty string 🤔, we should be able to deal with an option right 🤔
There was a problem hiding this comment.
There is an error
There was a problem hiding this comment.
you can make the optionImage accept undefined right?
|
Opened another PR |
|
Why close and re-create PR? |
6 tasks
|
Merge conflict was there..so I undo everything, created a new branch and committed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
Merge Checklist