feat: Added Avatars and profile pictures in userAutoComplete #8892
Conversation
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This looks broken
|
|
Sorry, I didn't understand..how is it broken.. |
enlarging the image such that the |
|
|
|
Better. The online dot could come to the bottom right of the avatar. Also prefix |
|
|
|
Yup! |
|
Updated! |
|
👋 Hi, @noufalrahim, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
| optionImage={(option: UserBareMinimum | UserModel) => | ||
| (option as UserModel).read_profile_picture_url || "" | ||
| } |
There was a problem hiding this comment.
if read_profile_picture_url is not present in UserBareMinimum but backend provides it, then add then move the read_profile_picture_url to UserBareMinimum instead.
| optionImage={(option: UserBareMinimum | UserModel) => | |
| (option as UserModel).read_profile_picture_url || "" | |
| } | |
| optionImage={(option: UserBareMinimum) => option.read_profile_picture_url} |
| <div className="w-full"> | ||
| <div className="flex w-full justify-between"> | ||
| <span> | ||
| {"@"} |
There was a problem hiding this comment.
@noufalrahim like said previously, this is a reusable component. Modifications made here will affect all other places. @ prefix is only supposed to be present for UserAutocompleteFormField not any other usages.
There was a problem hiding this comment.
So where am I supposed to add "@"
There was a problem hiding this comment.
can I add it in utils formatName?
There was a problem hiding this comment.
The username should have the prefix @, not the name
There was a problem hiding this comment.
You can add it in optionDescription of the UserAutocompleteFormField right?
|
I have a doubt regarding conflict.. How to resolve it.. |
|
merge latest develop into this branch and clear conflicts from the editor and push the merge commit. |
|
Opened another PR |
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
Merge Checklist
] Add specs that demonstrate bug / test a new feature.