Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant API calls in Vitals tab #8864

Merged
merged 4 commits into from
Oct 23, 2024

Conversation

Jacobjeevan
Copy link
Contributor

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

- fetch pain data along with rest of the graph data and pass it as a prop to PainDiagrams
- translations
Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 77c349d
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/6718fa4508b2520008ed3e74
😎 Deploy Preview https://deploy-preview-8864--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gigincg
Copy link
Member

gigincg commented Oct 23, 2024

@Jacobjeevan It's been partially fixed, but when you open the tab and refresh the page, there's still a redundant request going through.

image

https://deploy-preview-8864--care-ohc.netlify.app/facility/0c95c7f0-e1d2-4aff-83fa-933cef60d3a8/patient/7e8fc20f-02da-47f7-8c33-f2d8c7e52dd8/consultation/edfe0bd6-0f50-4a4c-8cd0-2d4ad0e9cea1/summary

@Jacobjeevan
Copy link
Contributor Author

@Jacobjeevan It's been partially fixed, but when you open the tab and refresh the page, there's still a redundant request going through.

image

https://deploy-preview-8864--care-ohc.netlify.app/facility/0c95c7f0-e1d2-4aff-83fa-933cef60d3a8/patient/7e8fc20f-02da-47f7-8c33-f2d8c7e52dd8/consultation/edfe0bd6-0f50-4a4c-8cd0-2d4ad0e9cea1/summary

It was a top-level re-render (caused by patientData), added it to the other checks we have. This should take care of extra calls in other tabs as well 👍

@nihal467
Copy link
Member

LGTM

Copy link

👋 Hi, @Jacobjeevan,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 23, 2024
@gigincg
Copy link
Member

gigincg commented Oct 23, 2024

@Jacobjeevan Can you clear the conflicts

@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Oct 23, 2024
@bodhish bodhish merged commit 160f745 into ohcnetwork:develop Oct 23, 2024
22 checks passed
Copy link

@Jacobjeevan Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

noufalrahim pushed a commit to noufalrahim/care_fe that referenced this pull request Oct 24, 2024
@Jacobjeevan Jacobjeevan deleted the issues/8861-vitals-api branch November 6, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redudant API Requests being made in the Vitals Tab
5 participants