Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove asset detail popup in asset configure's camera feed #8855

Conversation

Rishith25
Copy link
Contributor

@Rishith25 Rishith25 commented Oct 21, 2024

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@Rishith25 Rishith25 requested a review from a team as a code owner October 21, 2024 16:11
Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 1892b89
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/6717356d6bc07e000877344c
😎 Deploy Preview https://deploy-preview-8855--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

LGTM

src/Components/CameraFeed/CameraFeed.tsx Outdated Show resolved Hide resolved
src/Components/CameraFeed/CameraFeed.tsx Outdated Show resolved Hide resolved
src/Components/CameraFeed/CameraFeed.tsx Outdated Show resolved Hide resolved
src/Components/CameraFeed/ConfigureCamera.tsx Outdated Show resolved Hide resolved
src/Components/CameraFeed/ConfigureCamera.tsx Outdated Show resolved Hide resolved
src/Components/CameraFeed/ConfigureCamera.tsx Outdated Show resolved Hide resolved
src/Components/CameraFeed/ConfigureCamera.tsx Outdated Show resolved Hide resolved
src/Components/Assets/AssetConfigure.tsx Outdated Show resolved Hide resolved
src/Components/CameraFeed/CameraFeed.tsx Outdated Show resolved Hide resolved
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@rithviknishad rithviknishad changed the title Removal of camera name and pop up #8844 Remove asset detail popup in asset configure's camera feed Oct 22, 2024
@khavinshankar khavinshankar merged commit b1a1fad into ohcnetwork:develop Oct 22, 2024
33 checks passed
Copy link

@Rishith25 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

@Rishith25
Copy link
Contributor Author

@rithviknishad Can you please assign 2 story points for this

@rithviknishad
Copy link
Member

@Rishith25 for minor changes we assign 1 story point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the camera name and details pop-up from the camera feed component on the asset configuration page.
5 participants