Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bed management UI enhancement #8839

Conversation

Jacobjeevan
Copy link
Contributor

@Jacobjeevan Jacobjeevan commented Oct 21, 2024

Proposed Changes

image

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

- added translations to bed management
@Jacobjeevan Jacobjeevan requested a review from a team as a code owner October 21, 2024 04:38
Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 98a57de
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/6716a24ce485b20008fba745
😎 Deploy Preview https://deploy-preview-8839--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@bodhish bodhish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jacobjeevan
Copy link
Contributor Author

I'll take a look at the failing test 👍

@samholics
Copy link

samholics commented Oct 21, 2024

tested, working fine @nihal467
However is it possible to to display the description..now its not showing the full description.

@nihal467
Copy link
Member

image

  • use the full width of the page, on the left side, so it is aligned with the bed management heading

image

  • add a space between the white padding and the button when there is no bed in the location

@Jacobjeevan
Copy link
Contributor Author

image

* [ ]  use the full width of the page, on the left side, so it is aligned with the bed management heading

image

* [ ]  add a space between the white padding and the button when there is no bed in the location

Done 👍

@nihal467
Copy link
Member

LGTM

@@ -224,6 +224,7 @@
"add_beds": "Add Bed(s)",
"add_details_of_patient": "Add Details of Patient",
"add_location": "Add Location",
"add_new_beds": "Add New Bed(s)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khavinshankar khavinshankar merged commit 8c2ef01 into ohcnetwork:develop Oct 22, 2024
24 checks passed
Copy link

@Jacobjeevan Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

@Jacobjeevan Jacobjeevan deleted the issues/6974-bedManagement-enhancement branch November 6, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design Enhancement for Bed Management
6 participants