Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes greyed out 'Active Manage Bed' button in Location Management Page #8814 #8827

Merged
merged 8 commits into from
Oct 27, 2024
Merged

Fixes greyed out 'Active Manage Bed' button in Location Management Page #8814 #8827

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b8ae7f1
Fixes greyed out 'Active Manage Bed' button in Location Management Page
abhip161 Oct 18, 2024
6460119
Merge branch 'develop' into issues/8814/fix-active-manage-bed-button
nihal467 Oct 18, 2024
cb0d861
Refactored: Removed conditional classes, set button as disabled if to…
abhip161 Oct 21, 2024
fcb1fb9
Merge branch 'issues/8814/fix-active-manage-bed-button' of https://gi…
abhip161 Oct 21, 2024
bf88c2f
Update src/Components/Facility/LocationManagement.tsx
rithviknishad Oct 23, 2024
fd2f8ce
Fix: Removed cn and wrapped Manage Beds button in Link with dynamic href
abhip161 Oct 23, 2024
e3515fb
Fix: Removed cn and wrapped Manage Beds button in Link with dynamic href
abhip161 Oct 23, 2024
5055e2e
Merge branch 'develop' into issues/8814/fix-active-manage-bed-button
bodhish Oct 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Components/Facility/LocationManagement.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ const Location = ({
border
className={cn(
"mt-3 flex w-full items-center justify-between",
totalBeds != null && "opacity-50",
totalBeds != null && "opacity-100",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
totalBeds != null && "opacity-100",
totalBeds == null && "opacity-50",

Copy link
Contributor Author

@abhip161 abhip161 Oct 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @rithviknishad
if opacity-50 manage bed button will greyed out

if you want
opacity behaves correctly based on the totalBeds condition ??

When totalBeds is null, the button will have opacity-50, making it look greyed out.

When totalBeds has a value, the button will display with opacity-100, appearing fully visible.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should disable the button, why hack the class? Set disabled: true?

)}
href={`location/${id}/beds`}
>
Expand Down
Loading