-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Clearing Facilities Field Causes White Screen #8610 #8629
Fix: Clearing Facilities Field Causes White Screen #8610 #8629
Conversation
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@AdityaJ2305 It seems like you've made some partial changes. When you're clearing the input text, it should not remove the selected values from the dropdown. Instead, it should only clear the input field. This is the desired behavior from the user's perspective. Could you please adjust this accordingly? |
|
@AdityaJ2305 lint checks and cypress tests are failing. |
@AdityaJ2305 could you ensure prettier is working locally? Noticed code not formatted in a previous PR from you too. |
Thank you for the feedback! I'll ensure Prettier is set up and working locally for future PRs and going to make changes in current PR |
@AdityaJ2305 Could you please prioritize pushing the fix by the end of today? We need to address this issue as soon as possible before our upcoming weekly release. |
@rithviknishad Apologies my bad |
LGTM |
@AdityaJ2305 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
selectedFacility
state was encountering issues due to anull
value being passed by theAutoCompleteAsync
component when clicking the clear icon. To address this, I added a check to ensure that if the value isnull
, an empty array is passed instead.Screenshot of the
AutoCompleteAsync
Component:Video Recording:
Screen.Recording.2024-09-25.at.7.39.18.PM.mov
Reviewers:
@nihal467
@ohcnetwork/care-fe-code-reviewers
Merge Checklist: