Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Clearing Facilities Field Causes White Screen #8610 #8629

Conversation

AdityaJ2305
Copy link
Contributor

@AdityaJ2305 AdityaJ2305 commented Sep 25, 2024

Screenshot of the AutoCompleteAsync Component:

AutoCompleteAsync Component Screenshot

Video Recording:

Screen.Recording.2024-09-25.at.7.39.18.PM.mov

Reviewers:

@nihal467
@ohcnetwork/care-fe-code-reviewers

Merge Checklist:

  • Add specifications that demonstrate the bug fix or test the new feature.
  • Prepare a screenshot or demo video for the changelog entry and attach it to the issue.
  • Request peer reviews.

@AdityaJ2305 AdityaJ2305 requested a review from a team as a code owner September 25, 2024 14:22
Copy link

netlify bot commented Sep 25, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit ea151ab
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/66f68b0fe4c1a800088d0aff
😎 Deploy Preview https://deploy-preview-8629--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chakribontha
Copy link
Contributor

@AdityaJ2305 It seems like you've made some partial changes. When you're clearing the input text, it should not remove the selected values from the dropdown. Instead, it should only clear the input field. This is the desired behavior from the user's perspective. Could you please adjust this accordingly?

@AdityaJ2305
Copy link
Contributor Author

@AdityaJ2305 It seems like you've made some partial changes. When you're clearing the input text, it should not remove the selected values from the dropdown. Instead, it should only clear the input field. This is the desired behavior from the user's perspective. Could you please adjust this accordingly?

@chakribontha, in the screenshot, three facilities are selected: testing, Thiruvananthapuram Testing Other, Thiruvananthapuram and Testing Other12313, Thiruvananthapuram with “3 selected” shown as text. Clicking the clear icon should only remove the “3 selected” text, not the selected facilities below. If I understand correctly, the clear icon is meant to allow users to reset and choose facilities again. By only clearing the text, this purpose isn’t fully met.

Screenshot 2024-09-25 at 10 39 39 PM

@rithviknishad
Copy link
Member

@AdityaJ2305 lint checks and cypress tests are failing.

@rithviknishad
Copy link
Member

@AdityaJ2305 could you ensure prettier is working locally? Noticed code not formatted in a previous PR from you too.

@AdityaJ2305
Copy link
Contributor Author

AdityaJ2305 commented Sep 26, 2024

@AdityaJ2305 could you ensure prettier is working locally? Noticed code not formatted in a previous PR from you too.

Thank you for the feedback! I'll ensure Prettier is set up and working locally for future PRs and going to make changes in current PR

@nihal467
Copy link
Member

@AdityaJ2305 Could you please prioritize pushing the fix by the end of today? We need to address this issue as soon as possible before our upcoming weekly release.

@AdityaJ2305
Copy link
Contributor Author

@rithviknishad Apologies my bad

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit bbeab06 into ohcnetwork:develop Sep 27, 2024
24 checks passed
Copy link

@AdityaJ2305 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Add New User - Clearing Facilities Field Causes White Screen
5 participants