Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera Feed Fixes: Gracefully handle full-screen errors for unsupported devices; fixes clipping of content in certain sizes in landscape mode #7965

Merged
merged 8 commits into from
Jun 3, 2024

Conversation

rithviknishad
Copy link
Member

Proposed Changes

  • Fixes Camera Feed clipping in certain mobile sizes in landscape view.
  • Gracefully handle full-screen errors for unsupported devices
  • Rename "Select presets" to "More presets"

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner June 3, 2024 13:17
Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 3:33pm

Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 21c1ad1
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/665de21b2eaee90008911d64
😎 Deploy Preview https://deploy-preview-7965--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Jun 3, 2024

3 failed tests on run #2686 ↗︎

3 121 0 0 Flakiness 0

Details:

Camera Feed Fixes: Gracefully handle full-screen errors for unsupported devices;...
Project: CARE Commit: 21c1ad1e35
Status: Failed Duration: 04:04 💡
Started: Jun 3, 2024 3:37 PM Ended: Jun 3, 2024 3:42 PM
Failed  patient_consultation.cy.ts • 1 failed test • UI-Chrome

View Output

Test Artifacts
Patient Consultation in multiple combination > Internal Transfer within facility Patient with Domicilary Care Test Replay Screenshots
Failed  patient_registration.cy.ts • 1 failed test • UI-Chrome

View Output

Test Artifacts
Patient Creation with consultation > Patient Registration using the transfer with no consultation Test Replay Screenshots
Failed  patient_prescription.cy.ts • 1 failed test • UI-Chrome

View Output

Test Artifacts
Patient Medicine Administration > Add a new titrated medicine for a patient | Individual Administeration | Test Replay Screenshots

Review all test suite changes for PR #7965 ↗︎

@nihal467
Copy link
Member

nihal467 commented Jun 3, 2024

need to be tested on all device :

  • Windows Laptop 15.6 inch
  • Redmi Note 7 Pro (Android)
  • iPhone 14 Pro (Safari & Chrome)

Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for care-net failed.

Name Link
🔨 Latest commit be9bd11
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/665ddde767bf630008c9419f

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Jun 3, 2024
@rithviknishad rithviknishad removed the Deploy-Failed Deplyment is not showing preview label Jun 3, 2024
@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Jun 3, 2024
@nihal467
Copy link
Member

nihal467 commented Jun 3, 2024

LGTM, tested through tunnel

@rithviknishad rithviknishad removed the Deploy-Failed Deplyment is not showing preview label Jun 3, 2024
@khavinshankar khavinshankar merged commit 9addcae into develop Jun 3, 2024
54 of 62 checks passed
@khavinshankar khavinshankar deleted the rithviknishad/fix/camera-feed-ios branch June 3, 2024 15:57
Copy link

github-actions bot commented Jun 3, 2024

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Copy link

sentry-io bot commented Jun 4, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Failed to execute 'exitFullscreen' on 'Document': Document not active d(src/CAREUI/misc/Fullscreen) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants