Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean special characters in phone number in whatsapp link #7964

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

khavinshankar
Copy link
Member

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 11:33am

Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 6d23c6b
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/665da9de1758340008e3f126
😎 Deploy Preview https://deploy-preview-7964--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Jun 3, 2024

2 failed tests on run #2684 ↗︎

2 122 0 0 Flakiness 0

Details:

clean special characters in phone number in whatsapp link
Project: CARE Commit: 6d23c6b94e
Status: Failed Duration: 03:53 💡
Started: Jun 3, 2024 11:37 AM Ended: Jun 3, 2024 11:41 AM
Failed  patient_consultation.cy.ts • 1 failed test • UI-Chrome

View Output

Test Artifacts
Patient Consultation in multiple combination > Internal Transfer within facility Patient with Domicilary Care Test Replay Screenshots
Failed  patient_registration.cy.ts • 1 failed test • UI-Chrome

View Output

Test Artifacts
Patient Creation with consultation > Patient Registration using the transfer with no consultation Test Replay Screenshots

Review all test suite changes for PR #7964 ↗︎

@nihal467
Copy link
Member

nihal467 commented Jun 3, 2024

LGTM, it should be fixing whatsapp redirection in safari , along with that tested on all devices

@gigincg gigincg merged commit 6e4114b into develop Jun 3, 2024
57 of 62 checks passed
@gigincg gigincg deleted the clean-whatsapp-phone branch June 3, 2024 12:59
Copy link

github-actions bot commented Jun 3, 2024

@khavinshankar Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants