Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes up/down arrow of numeric inputs not clickable in facility create and other places #7931

Merged
merged 2 commits into from
May 29, 2024
Merged

fixes up/down arrow of numeric inputs not clickable in facility create and other places #7931

merged 2 commits into from
May 29, 2024

Conversation

rithviknishad
Copy link
Member

Proposed Changes

Affects the following places

  • Numeric fields in Facility Create
  • Numeric fields "weight" and "height" in Consultation Form
  • Numeric field "Age" in patient register form

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner May 28, 2024 16:22
@vercel Vercel
Copy link

vercel bot commented May 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 6:05am

@netlify Netlify
Copy link

netlify bot commented May 28, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit ec1770d
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6656c5a2aaf1c80008319bc6
😎 Deploy Preview https://deploy-preview-7931--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress Cypress
Copy link

cypress bot commented May 28, 2024 •
edited
Loading

Passing run #2662 ↗︎

0 124 0 0 Flakiness 0

Details:

fixes up/down arrow of numeric inputs not clickable in facility create and other...
Project: CARE Commit: ec1770da77
Status: Passed Duration: 03:25 💡
Started: May 29, 2024 6:10 AM Ended: May 29, 2024 6:13 AM

Review all test suite changes for PR #7931 ↗︎

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit cf5f1c3 into develop May 29, 2024
62 checks passed
@khavinshankar khavinshankar deleted the rithviknishad/fix/up-down-pointer-none branch May 29, 2024 06:13
@github-actions GitHub Actions
Copy link

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees
No one assigned
Labels
needs review tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to Change the Values using Upward and Downward arrow
3 participants
@rithviknishad @nihal467 @khavinshankar