Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Discontinue, Administer, Archive Administration & Edit prescription for discharged patients; disallow titrated prescriptions for discharge prescriptions; and more... #7675

Merged
merged 4 commits into from
Apr 21, 2024
Merged

Disable Discontinue, Administer, Archive Administration & Edit prescription for discharged patients; disallow titrated prescriptions for discharge prescriptions; and more... #7675

merged 4 commits into from
Apr 21, 2024

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Apr 21, 2024 •
edited
Loading

Proposed Changes

  • Fixes Titrated dose is not shown properly in the discharge information card #7672
  • Corrects label for dosage field in discharged info prescriptions table.
  • Prevent prescription row layout shift when any related modal is opened.
  • Disable Discontinue, Administer, Archive Administration & Edit prescription buttons if discharged.
  • Disable titrated prescriptions for discharge prescriptions.

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad added needs testing needs review P1 breaking issue or vital feature labels Apr 21, 2024
@rithviknishad rithviknishad requested a review from Ashesh3 April 21, 2024 14:58
@rithviknishad rithviknishad requested a review from a team as a code owner April 21, 2024 14:58
@vercel Vercel
Copy link

vercel bot commented Apr 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2024 3:39pm

@netlify Netlify
Copy link

netlify bot commented Apr 21, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit dfede2c
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/662533118cb522000845a1c9
😎 Deploy Preview https://deploy-preview-7675--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rithviknishad rithviknishad changed the title Issues/7672/titrated prescription patches2 Fixes incorrect label for dosage column in discharge info; disallow discontinue/administer/edit prescription for discharged patients; disallow titrated prescriptions for discharge prescriptions Apr 21, 2024
@rithviknishad rithviknishad changed the title Fixes incorrect label for dosage column in discharge info; disallow discontinue/administer/edit prescription for discharged patients; disallow titrated prescriptions for discharge prescriptions Disallow discontinue/administer/edit prescription for discharged patients; disallow titrated prescriptions for discharge prescriptions; and more... Apr 21, 2024
@cypress Cypress
Copy link

cypress bot commented Apr 21, 2024 •
edited
Loading

Passing run #2401 ↗︎

0 119 0 0 Flakiness 0

Details:

Disallow discontinue/administer/edit prescription for discharged patients; disal...
Project: CARE Commit: dfede2cca5
Status: Passed Duration: 03:03 💡
Started: Apr 21, 2024 4:13 PM Ended: Apr 21, 2024 4:16 PM

Review all test suite changes for PR #7675 ↗︎

@rithviknishad rithviknishad changed the title Disallow discontinue/administer/edit prescription for discharged patients; disallow titrated prescriptions for discharge prescriptions; and more... Disallow discontinue/administer/archive/edit prescription for discharged patients; disallow titrated prescriptions for discharge prescriptions; and more... Apr 21, 2024
@rithviknishad rithviknishad changed the title Disallow discontinue/administer/archive/edit prescription for discharged patients; disallow titrated prescriptions for discharge prescriptions; and more... Disable Discontinue, Administer, Archive Administration & Edit prescription for discharged patients; disallow titrated prescriptions for discharge prescriptions; and more... Apr 21, 2024
@nihal467
Copy link
Member

LGTM

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 83f64d6 into develop Apr 21, 2024
64 of 65 checks passed
@khavinshankar khavinshankar deleted the issues/7672/titrated-prescription-patches2 branch April 21, 2024 16:34
@github-actions GitHub Actions
Copy link

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@Ashesh3 Ashesh3 Awaiting requested review from Ashesh3

Assignees
No one assigned
Labels
needs review P1 breaking issue or vital feature tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Titrated dose is not shown properly in the discharge information card
3 participants
@rithviknishad @nihal467 @khavinshankar