Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to node v20 #7508

Merged
merged 5 commits into from
Apr 2, 2024
Merged

Upgrade to node v20 #7508

merged 5 commits into from
Apr 2, 2024

Conversation

rithviknishad
Copy link
Member

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner April 1, 2024 08:19
@vercel Vercel
Copy link

vercel bot commented Apr 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 4:57am

@netlify Netlify
Copy link

netlify bot commented Apr 1, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit ba46693
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/660b9009c113700008f4a159
😎 Deploy Preview https://deploy-preview-7508--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rithviknishad
Copy link
Member Author

rithviknishad commented Apr 1, 2024 •
edited
Loading

Lint errors have been fixed in #7469

@cypress Cypress
Copy link

cypress bot commented Apr 1, 2024 •
edited
Loading

Passing run #2313 ↗︎

0 114 0 0 Flakiness 0

Details:

Upgrade to node v20
Project: CARE Commit: 40d6465034
Status: Passed Duration: 02:51 💡
Started: Apr 1, 2024 11:53 AM Ended: Apr 1, 2024 11:56 AM

Review all test suite changes for PR #7508 ↗︎

sainak
sainak reviewed Apr 1, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@rithviknishad rithviknishad requested a review from sainak April 1, 2024 09:41
@sainak
Copy link
Member

sainak commented Apr 1, 2024

https://github.com/coronasafe/care_fe/blob/develop/.github/workflows/cypress.yaml
is missing setup node step

khavinshankar
khavinshankar approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor suggestion, lets use a LTS version

netlify.toml Outdated Show resolved Hide resolved
@khavinshankar khavinshankar merged commit 8dfa65d into develop Apr 2, 2024
63 of 64 checks passed
@khavinshankar khavinshankar deleted the node-20 branch April 2, 2024 05:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Ashesh3 pushed a commit to UdaySagar-Git/care_fe that referenced this pull request Apr 2, 2024
@rithviknishad @Ashesh3
Upgrade to node v20 (ohcnetwork#7508)
f0c7c3e 
* Upgrade to node v20

* use node `>=20.5.0`

* switch to using `.node-version`

* Add setup node step for cypress

* switch to use LTS
Ashesh3 pushed a commit to UdaySagar-Git/care_fe that referenced this pull request Apr 2, 2024
@rithviknishad @Ashesh3
Upgrade to node v20 (ohcnetwork#7508)
c2a5895 
* Upgrade to node v20

* use node `>=20.5.0`

* switch to using `.node-version`

* Add setup node step for cypress

* switch to use LTS
Ashesh3 pushed a commit to UdaySagar-Git/care_fe that referenced this pull request Apr 2, 2024
@rithviknishad @Ashesh3
Upgrade to node v20 (ohcnetwork#7508)
82d048a 
* Upgrade to node v20

* use node `>=20.5.0`

* switch to using `.node-version`

* Add setup node step for cypress

* switch to use LTS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sainak sainak sainak approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@Ashesh3 Ashesh3 Ashesh3 approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade care to node v20
4 participants
@rithviknishad @sainak @Ashesh3 @khavinshankar