Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix blood pressure being negative values when field is cleared #6986

Merged
merged 3 commits into from
Jan 6, 2024
Merged

Fix blood pressure being negative values when field is cleared #6986

merged 3 commits into from
Jan 6, 2024

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jan 6, 2024 •
edited by nihal467
Loading

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner January 6, 2024 13:16
@netlify Netlify
Copy link

netlify bot commented Jan 6, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit c0c60b9
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/659953e7cc15e50008ae8043
😎 Deploy Preview https://deploy-preview-6986--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vercel Vercel
Copy link

vercel bot commented Jan 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2024 1:22pm

@rithviknishad rithviknishad requested a review from Ashesh3 January 6, 2024 13:16
@cypress Cypress
Copy link

cypress bot commented Jan 6, 2024 •
edited
Loading

Passing run #1839 ↗︎

0 95 0 0 Flakiness 0

Details:

Fix blood pressure being negative values when field is cleared
Project: CARE Commit: c0c60b995a
Status: Passed Duration: 02:43 💡
Started: Jan 6, 2024 1:25 PM Ended: Jan 6, 2024 1:28 PM

Review all test suite changes for PR #6986 ↗︎

@nihal467
Copy link
Member

nihal467 commented Jan 6, 2024 •
edited
Loading

test to be completed

  • check the MEWS missing alert and mews score operation
  • create a log update with bp and without bp
  • edit a log update and remove/add the bp data
  • verify the chart review in the patient consultation page
  • verify the copied value to normal and critical care update

@nihal467
Copy link
Member

nihal467 commented Jan 6, 2024

LGTM

@khavinshankar khavinshankar merged commit fedb2e2 into develop Jan 6, 2024
@khavinshankar khavinshankar deleted the dailyrounds/fix-negative-bp branch January 6, 2024 13:52
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2024

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BP chart is showing -1 value in the patient consultation page
4 participants
@rithviknishad @nihal467 @Ashesh3 @khavinshankar