Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add video connect link and Cypress Tests for User Profile #6924

Merged
merged 7 commits into from
Jan 10, 2024

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Dec 26, 2023

Resolves #6641
Backend PR: ohcnetwork/care#1785

This pull request adds a new field called "video_connect_link" to the user profile. Users can now enter a video conference link in their profile, which will be displayed on their profile page.

image
image
image

@Ashesh3 Ashesh3 requested a review from a team as a code owner December 26, 2023 18:46
Copy link

vercel bot commented Dec 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 10:06am

Copy link

netlify bot commented Dec 26, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 64523a9
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/659e6bfef634440008fd5162
😎 Deploy Preview https://deploy-preview-6924--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Dec 26, 2023

1 failed test on run #1855 ↗︎

1 97 0 0 Flakiness 0

Details:

Add video connect link and Cypress Tests for User Profile
Project: CARE Commit: 64523a93c3
Status: Failed Duration: 02:32 💡
Started: Jan 10, 2024 10:09 AM Ended: Jan 10, 2024 10:12 AM
Failed  cypress/e2e/patient_spec/patient_manage.cy.ts • 1 failed test

View Output

Test Artifacts
Patient > Discharge a patient Test Replay Screenshots

Review all test suite changes for PR #6924 ↗︎

@nihal467
Copy link
Member

nihal467 commented Jan 1, 2024

@Ashesh3 the backend is marked for discussion

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ashesh3

The data fetching logic filters by doctors that has "alt phone number" only. This should be updated to have an or filter on video link field too right?

Ref. line https://github.com/coronasafe/care_fe/pull/6924/files#diff-f15a132265ab339453f06bc7dc6b773802090dfba335c46051a309b512de2060R30

@Ashesh3
Copy link
Member Author

Ashesh3 commented Jan 3, 2024

@Ashesh3

The data fetching logic filters by doctors that has "alt phone number" only. This should be updated to have an or filter on video link field too right?

Ref. line #6924 (files)

Nice catch! Fixed. thanks.

@nihal467
Copy link
Member

LGTM

@Ashesh3 Ashesh3 changed the title Add video connect link to user profile Add video connect link and Cypress Tests for User Profile Jan 10, 2024
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 5cf75e8 into develop Jan 10, 2024
34 of 38 checks passed
@khavinshankar khavinshankar deleted the user-connect-link branch January 10, 2024 14:05
Copy link

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding support for gmeet/zoom/ any other video call to doctor connect
4 participants