Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow route to facility to be edited if null #6742

Merged

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Nov 28, 2023

WHAT

🤖[deprecated] Generated by Copilot at 9fd5cda

Prevent route_to_facility field from being overwritten in consultation update form. Allow editing the field only if it was not set before.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖[deprecated] Generated by Copilot at 9fd5cda

  • Prevent editing the route_to_facility field in the consultation update form if it was already set (link)

@rithviknishad rithviknishad requested a review from a team as a code owner November 28, 2023 08:21
Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 9fd5cda
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6565a31220bc1f0008d15efe
😎 Deploy Preview https://deploy-preview-6742--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Nov 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview Nov 28, 2023 8:21am

@rithviknishad rithviknishad added urgent needs testing P1 breaking issue or vital feature labels Nov 28, 2023
Copy link

cypress bot commented Nov 28, 2023

Passing run #1638 ↗︎

0 87 0 0 Flakiness 0

Details:

Allow route to facility to be edited if null
Project: CARE Commit: 9fd5cda77e
Status: Passed Duration: 02:21 💡
Started: Nov 28, 2023 8:25 AM Ended: Nov 28, 2023 8:27 AM

Review all test suite changes for PR #6742 ↗︎

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 5cde457 into develop Nov 28, 2023
36 of 37 checks passed
@khavinshankar khavinshankar deleted the patch/consultation-allow-edit-route-to-facility-if-null branch November 28, 2023 10:04
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 breaking issue or vital feature tested urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Route to facility for old patient record is marked null
3 participants