Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Cypress Test | Verify Facility Advance Filter | Facility Tab #6736

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

nihal467
Copy link
Member

@nihal467 nihal467 commented Nov 27, 2023

WHAT

🤖[deprecated] Generated by Copilot at 2159a59

This pull request adds and improves test automation for the facility homepage and facility creation features. It introduces a new test case for the advanced filter functionality, and refactors some code and methods to enhance readability and reusability. It also updates the page object class FacilityCreation and the method clickUpdateFacilityType to handle different facility types.

Proposed Changes

  • Fixes #issue?
  • Change 1
  • Change 2
  • More?

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖[deprecated] Generated by Copilot at 2159a59

  • Rename file and test suite to facility_homepage.cy.ts and Facility Homepage to reflect new scope (link)
  • Import UserPage class for common UI methods (link)
  • Declare constants for state, district, and facility type values (link)
  • Add test case to verify advanced filter functionality on facility homepage (link)
  • Modify clickUpdateFacilityType method to accept facility type parameter in both facility.cy.ts and FacilityCreation.ts (link, link)
  • Add methods to verify state, district, and facility type badges on facility homepage in FacilityCreation.ts (link)

@nihal467 nihal467 requested a review from a team as a code owner November 27, 2023 20:56
Copy link

netlify bot commented Nov 27, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 2159a59
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65650263487c4b0008f7755a
😎 Deploy Preview https://deploy-preview-6736--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Nov 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview Nov 27, 2023 8:56pm

Copy link

cypress bot commented Nov 27, 2023

Passing run #1635 ↗︎

0 88 0 0 Flakiness 0

Details:

New Cypress Test | Verify Facility Advance Filter | Facility Tab
Project: CARE Commit: 2159a591a0
Status: Passed Duration: 02:21 💡
Started: Nov 27, 2023 8:59 PM Ended: Nov 27, 2023 9:01 PM

Review all test suite changes for PR #6736 ↗︎

@khavinshankar khavinshankar merged commit a18016b into develop Nov 29, 2023
37 checks passed
@khavinshankar khavinshankar deleted the test-facility-advancefilter branch November 29, 2023 14:26
Copy link

@nihal467 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants