Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medibase Search: Skip showing selected option search results when query is present #6284

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Sep 13, 2023

WHAT

🤖 Generated by Copilot at a91881e

This pull request improves the functionality and user experience of the Autocomplete component and its usage in the MedibaseAutocompleteFormField component. It clears the query state on blur and preserves the selected value as an option when the query is empty.

Proposed Changes

image image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at a91881e

  • Clear the query state of the Autocomplete component when the input loses focus to prevent the query from persisting (link)
  • Return only the field value as an option when the query is empty in the MedibaseAutocompleteFormField component to preserve the selected value and avoid unnecessary API requests (link)

@rithviknishad rithviknishad requested a review from a team September 13, 2023 15:47
@rithviknishad rithviknishad requested a review from a team as a code owner September 13, 2023 15:47
@vercel
Copy link

vercel bot commented Sep 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2023 3:48pm

@netlify
Copy link

netlify bot commented Sep 13, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit a91881e
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6501d9984571a100075c791c
😎 Deploy Preview https://deploy-preview-6284--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress
Copy link

cypress bot commented Sep 13, 2023

Passing run #1242 ↗︎

0 71 0 0 Flakiness 0

Details:

Merge a91881e into cc6b570...
Project: CARE Commit: 7aa2ffb6ec ℹ️
Status: Passed Duration: 07:13 💡
Started: Sep 13, 2023 3:52 PM Ended: Sep 13, 2023 3:59 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@rithviknishad rithviknishad changed the title Skip showing selected option search results when query is present Medibase Search: Skip showing selected option search results when query is present Sep 14, 2023
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 9e9fa16 into develop Sep 19, 2023
@khavinshankar khavinshankar deleted the fixes#6283 branch September 19, 2023 22:17
@github-actions
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip showing selected option in async autocomplete form fields (Medibase Medicine Search)
3 participants