Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kanban flow #5406

Merged
merged 12 commits into from
Apr 26, 2023
Merged

Kanban flow #5406

merged 12 commits into from
Apr 26, 2023

Conversation

khavinshankar
Copy link
Member

@khavinshankar khavinshankar commented Apr 25, 2023

WHAT

🤖 Generated by Copilot at 864be22

This pull request updates the shifting components and constants to support different modes of shifting based on the wartime_shifting configuration option. This allows for more flexibility and clarity in the shifting workflow and UI. It also fixes some minor issues with the button styling and the translation of the completed term.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 864be22

  • Rename and add constants for shifting status options in peacetime and wartime modes (link, link)
  • Import and use the appropriate constants in ShiftCreate, BoardView, ListFilter, and ShiftDetailsUpdate components based on the wartime_shifting configuration option (link, link, link, link, link, link, link, link, link, link)
  • Import and use the FieldChangeEvent type in ShiftDetailsUpdate component to type the handleChange function (link)
  • Change the translation value of the completed key from Completed to Archived in Common.json file (link)

@khavinshankar khavinshankar requested a review from a team April 25, 2023 12:08
@khavinshankar khavinshankar requested a review from a team as a code owner April 25, 2023 12:08
@vercel
Copy link

vercel bot commented Apr 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2023 2:30pm

@netlify
Copy link

netlify bot commented Apr 25, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit d7e7093
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6449355905e8370008144700
😎 Deploy Preview https://deploy-preview-5406--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Apr 25, 2023
@khavinshankar khavinshankar added urgent needs testing P1 breaking issue or vital feature labels Apr 25, 2023
@nihal467
Copy link
Member

@khavinshankar
image

the kanban board and the status dropdown is not matching

@nihal467
Copy link
Member

LGTM

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Apr 26, 2023
@github-actions
Copy link

👋 Hi, @khavinshankar,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@gigincg
Copy link
Member

gigincg commented Apr 26, 2023

@nihal467 Can you test the status field in ShiftingDetailsUpdate page?

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Apr 26, 2023
@nihal467
Copy link
Member

@khavinshankar
image

unable to update status

@nihal467
Copy link
Member

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

@gigincg gigincg merged commit f013a27 into develop Apr 26, 2023
@github-actions
Copy link

@khavinshankar We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@sainak sainak deleted the kanban-flow branch January 19, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure P1 breaking issue or vital feature tested urgent
Projects
None yet
3 participants