Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated ShiftingBoard.tsx from MaterialUI to Custom Components #5324

Merged
merged 5 commits into from
Apr 18, 2023
Merged

Migrated ShiftingBoard.tsx from MaterialUI to Custom Components #5324

merged 5 commits into from
Apr 18, 2023

Conversation

suprabathk
Copy link
Contributor

Proposed Changes

  • Migrate all Material UI components to use new Care UI / custom components.

  • Migrate all Material UI icons to use.

  • Migrate PageTitle to Page component if any.

  • Fixes Replace Material UI components in src/Components/Shifting/ShiftingBoard.tsx: #5000

  • Change 1
    Migrated from all MaterialUI components to Custom made components.

  • Change 2
    Changed the shade of text color in ConfirmDialogV2 component from 500 to 600 for better visibility.

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@suprabathk suprabathk requested a review from a team April 12, 2023 08:11
@suprabathk suprabathk requested a review from a team as a code owner April 12, 2023 08:11
@suprabathk suprabathk requested a review from mathew-alex April 12, 2023 08:11
@vercel
Copy link

vercel bot commented Apr 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2023 11:40am

@netlify
Copy link

netlify bot commented Apr 12, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 41c3001
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/643d2fdf450c790008a75b3b
😎 Deploy Preview https://deploy-preview-5324--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

rithviknishad
rithviknishad approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor suggestions. The transfer button's width and size are not consistent with the view details button above it.

image

suprabathk and others added 2 commits April 12, 2023 04:23
@suprabathk @rithviknishad
Update src/Components/Shifting/ShiftingBoard.tsx
2c527e1 
Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>
@suprabathk @rithviknishad
Update src/Components/Shifting/ShiftingBoard.tsx
5080395 
Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>
@bodhish
Copy link
Member

bodhish commented Apr 12, 2023

copilot:summary

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit f7b6cec into ohcnetwork:develop Apr 18, 2023
@Sushreebadhulika Sushreebadhulika mentioned this pull request Oct 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace Material UI components in src/Components/Shifting/ShiftingBoard.tsx:
5 participants
@suprabathk @bodhish @nihal467 @rithviknishad @khavinshankar