Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate all existing usages PhoneNumberField to PhoneNumberFormField and deprecates the legacy component #4527

Merged
merged 12 commits into from
Jan 6, 2023
Merged

Migrate all existing usages PhoneNumberField to PhoneNumberFormField and deprecates the legacy component #4527

merged 12 commits into from
Jan 6, 2023

Conversation

rithviknishad
Copy link
Member

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team January 6, 2023 13:13
@rithviknishad rithviknishad requested a review from a team as a code owner January 6, 2023 13:13
@vercel
Copy link

vercel bot commented Jan 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Jan 6, 2023 at 1:34PM (UTC)

@netlify
Copy link

netlify bot commented Jan 6, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit d0a1ac8
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63b822b01594f200083d74d0
😎 Deploy Preview https://deploy-preview-4527--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

nihal467 commented Jan 6, 2023 •
edited
Loading

@rithviknishad
image

when we hit the cross button, all the fields validation are been run automatically, is it intentional

@rithviknishad
Copy link
Member Author

@nihal467 should be fixed now

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 20 Code Smells

No Coverage information No Coverage information
10.2% 10.2% Duplication

@nihal467
Copy link
Member

nihal467 commented Jan 6, 2023

LGTM

@khavinshankar khavinshankar merged commit b25aad6 into develop Jan 6, 2023
@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Jan 6, 2023
@rithviknishad rithviknishad mentioned this pull request Feb 7, 2023
Closed
41 tasks
@rithviknishad rithviknishad deleted the fix-phone-form-field branch July 26, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
cypress failed pull request with cypress test failure tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alignment issue in the asset creation page
3 participants
@rithviknishad @nihal467 @khavinshankar