Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Tailwind the Add User page + cypress tests for user feature #4378

Merged
merged 9 commits into from
Jan 16, 2023
Merged

fix: Tailwind the Add User page + cypress tests for user feature #4378

merged 9 commits into from
Jan 16, 2023

Conversation

aeswibon
Copy link
Contributor

@aeswibon aeswibon commented Dec 20, 2022 •
edited by rithviknishad
Loading

Bug Fix

Proposed Changes

  • Tailwind the Add User page
  • Fixes cypress test for users

Associated Issue

Screenshots

image
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug/test a new feature.
  • Update product documentation
  • Ensure that UI text is kept in I18n files
  • Prep the screenshot or demo video for the changelog entry, and attach it to issue
  • Request for Peer Reviews
  • Completion of QA

@aeswibon aeswibon requested a review from a team December 20, 2022 19:01
@aeswibon aeswibon requested a review from a team as a code owner December 20, 2022 19:01
@aeswibon aeswibon requested a review from mathew-alex December 20, 2022 19:01
@vercel
Copy link

vercel bot commented Dec 20, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 16, 2023 at 4:05PM (UTC)

@netlify
Copy link

netlify bot commented Dec 20, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 2a34216
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63c5752b0679cb0009c756ce
😎 Deploy Preview https://deploy-preview-4378--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rithviknishad
Copy link
Member

@cp-coder marking it as hold, since we will now have FormField compliant components coming, for example SelectFormField shall be used in place of SelectMenuV2.

FormField components have similar design and API to that of TextFormField which you have used so far in many places.

@rithviknishad
Copy link
Member

Coming via #4309

@rithviknishad
Copy link
Member

unholding coz just realized its a plug-and-play replacement anyways which can be done later too :)

@ohcnetwork ohcnetwork deleted a comment from sonarqubecloud bot Dec 22, 2022
@nihal467
Copy link
Member

LGTM

@khavinshankar
Copy link
Member

@cp-coder do fix the failing cypress tests

@khavinshankar khavinshankar added the cypress failed pull request with cypress test failure label Dec 22, 2022
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Dec 22, 2022
@github-actions
Copy link

👋 Hi, @cp-coder,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@aeswibon aeswibon removed the merge conflict pull requests with merge conflict label Dec 25, 2022
@khavinshankar
Copy link
Member

@cp-coder seems there are failing tests, please do check

@github-actions
Copy link

👋 Hi, @cp-coder,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Dec 28, 2022
@aeswibon aeswibon removed the merge conflict pull requests with merge conflict label Jan 1, 2023
@khavinshankar
Copy link
Member

@cp-coder do check the cypress tests

@khavinshankar khavinshankar added the cypress failed pull request with cypress test failure label Jan 3, 2023
@aparnacoronasafe
Copy link

@nihal467 @rithviknishad When are we expecting this to go live?

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jan 4, 2023
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

👋 Hi, @cp-coder,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@aeswibon aeswibon removed merge conflict pull requests with merge conflict cypress failed pull request with cypress test failure labels Jan 14, 2023
@github-actions
Copy link

👋 Hi, @cp-coder,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jan 16, 2023
@gigincg gigincg removed the merge conflict pull requests with merge conflict label Jan 16, 2023
@gigincg gigincg merged commit 62e8902 into ohcnetwork:develop Jan 16, 2023
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 22 Code Smells

No Coverage information No Coverage information
2.9% 2.9% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
6 participants
@aeswibon @rithviknishad @nihal467 @khavinshankar @aparnacoronasafe @gigincg