Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade the facility creation component to tailwind components #4315

Merged
merged 4 commits into from
Dec 16, 2022

Conversation

aeswibon
Copy link
Contributor

@aeswibon aeswibon commented Dec 15, 2022

Feature Request

Proposed Changes

  • Replaced MUI components with Tailwind components for the Facility Create/Update page

Associated Issue

Screenshot

image
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug/test a new feature.
  • Update product documentation
  • Ensure that UI text is kept in I18n files
  • Prep the screenshot or demo video for the changelog entry, and attach it to issue
  • Request for Peer Reviews
  • Completion of QA

@aeswibon aeswibon requested a review from a team December 15, 2022 15:00
@aeswibon aeswibon requested a review from a team as a code owner December 15, 2022 15:00
@aeswibon aeswibon requested a review from bodhish December 15, 2022 15:00
@netlify
Copy link

netlify bot commented Dec 15, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 22d3920
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/639c5506792b9c0008eb92af
😎 Deploy Preview https://deploy-preview-4315--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vercel
Copy link

vercel bot commented Dec 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 16, 2022 at 11:24AM (UTC)

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cp-coder I see that you've overridden the font size of all the FieldLabels used. The FieldLabel uses the font size per the Figma design, avoid overriding it so that we have a consistent design across the platform.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nihal467
Copy link
Member

LGTM

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 4 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 18 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khavinshankar
Copy link
Member

@nihal467 @cp-coder there is a minor problem, once the state is selected we can't select 'choose state' again, and the same with the district, local body, and ward too. I am anyways merging this pr because those are mandatory fields.

@khavinshankar khavinshankar merged commit 12df44e into ohcnetwork:develop Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade the facility creation component to Custom Components
4 participants