Fixed facility search offset #4004
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
test approved |
| @@ -98,7 +98,7 @@ export const HospitalList = (props: any) => { | |||
| facility_type: qParams.facility_type, | |||
| kasp_empanelled: qParams.kasp_empanelled, | |||
| }; | |||
|
|
|||
| if (params.search_text) params.offset = 0; | |||
There was a problem hiding this comment.
@GokulramGHV this only works for the search by name filter and will not work for others, so why not add a page parameter as 1 when we make a request related to filters
There was a problem hiding this comment.
There was a problem hiding this comment.
@GokulramGHV @khavinshankar @nihal467 the changes suggested here are fixed in #4017.
Merging this PR to develop will have no effect once #4017 is merged. since the reset method used in this PR is not based on query parameters. The changes were overridden in #4017
|
Closing this pr, ref: #4017 |
Fixes #4003
Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist