Tailwind SearchInput with keyboard shortcut to focus
#3920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
SearchInputSearchInput with keyboard shortcut to focus
|
👋 Hi, @rithviknishad, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
…_fe into tailwind/search-input
|
SonarCloud Quality Gate failed.
|
|
is it intentional |
|
@nihal467 yes, the colors is intentional. inspired from |
|
LGTM, marking it as team discussion required for final approval |
|
test approved |
khavinshankar
approved these changes
Nov 10, 2022
14 tasks
aeswibon
pushed a commit
to aeswibon/care_fe
that referenced
this pull request
Dec 8, 2022
* `TextFormField` explicit override to break design * `TextFormField` support leading and trailing * fix issues with inheriting `form-input` properly * utility: `iOS` const to detect if device is iOS * `TextFormField` support ref forwarding * Make component: `SearchInput` * replace search input in Assets Page * utils: detect Apple device instead of iOS * `TextFormField`: leadingFocused, trailingFocused * hide clear icon for input type=search (chrome+ie) * `SearchInput`: hotkey for clear + custom focus hotkey * `SearchInput`: allow being secondary searchbar * `FormField`: label as optional, autohide * `SearchInput`: default sizing preference * Replace old SearchInputs to tailwind search input * delete old search box * undo removal of postcss loader when merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Ctrl K(⌘Kon Apple devices)2022-11-02.14-57-16.mp4
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist