Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patient questionnaire minor fix #11103

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

Jacobjeevan
Copy link
Contributor

@Jacobjeevan Jacobjeevan commented Mar 7, 2025

Proposed Changes

  • Revert some of the changes
    • Add button in Updates

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA in Mobile Devices
  • Completion of QA in Desktop Devices

Summary by CodeRabbit

  • New Features

    • Introduced a new updates section in patient details that offers an intuitive interface with a dynamically routed button for accessing questionnaire pages, complete with multilingual support.
  • UI Improvements

    • Streamlined the display of questionnaire responses by removing the previous navigation elements, resulting in a cleaner, more focused user experience.

@Jacobjeevan Jacobjeevan requested a review from a team as a code owner March 7, 2025 06:37
Copy link
Contributor

coderabbitai bot commented Mar 7, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request removes the use of the facilityId prop and associated navigation elements from the QuestionnaireResponsesList component. Instead, it adds a new component called Updates in the patient details tab. The Updates component now handles dynamic linking based on the presence of a facilityId and incorporates the questionnaire responses by embedding the modified QuestionnaireResponsesList. Additionally, the patient details tab is updated to use the new Updates component for the updates route.

Changes

File(s) Change Summary
src/components/Facility/ConsultationDetails/QuestionnaireResponsesList.tsx Removed facilityId from function parameters; added encounter prop; updated query parameters to use encounter?.id; removed navigation header and button for patient updates.
src/components/Patient/PatientDetailsTab/index.tsx Removed the import of QuestionnaireResponsesList and added an import for Updates; updated patientTabs to render the Updates component for the "updates" route.
src/components/Patient/PatientDetailsTab/patientUpdates.tsx Added new Updates component that leverages useTranslation for i18n; dynamically builds a questionnaire link using facilityId; includes the QuestionnaireResponsesList for display.

Sequence Diagram(s)

sequenceDiagram
    participant PDT as PatientDetailsTab
    participant UPD as Updates Component
    participant QRL as QuestionnaireResponsesList
    participant Nav as Navigation Service

    PDT->>UPD: Render "updates" tab
    UPD->>QRL: Pass patientId to display responses
    UPD->>Nav: On button click, navigate to questionnaire (using facilityId if available)
Loading

Possibly related PRs

  • Migration to useQuery: Removed PaginatedList.tsx and Update Dependent Components #10350: The changes in the main PR, which involve modifications to the QuestionnaireResponsesList component, are related to the retrieved PR as both involve updates to the same component, specifically in how data fetching and rendering are handled.
  • Patient Tabs Fixes #10642: The changes in the main PR regarding the QuestionnaireResponsesList component's props and functionality are related to the modifications in the patientUpdates.tsx file of the retrieved PR, as both involve the removal of the facilityId prop and adjustments to navigation elements.
  • SubQuestion | Pass in encounter Id #11032: The changes in the main PR, which involve the addition of an encounter prop to the QuestionnaireResponsesList component, are related to the retrieved PR that introduces an encounterId prop to the QuestionGroup component, as both modifications enhance the handling of encounter-specific data within their respective components.

Suggested labels

needs review, tested, changes required

Suggested reviewers

  • rithviknishad

Poem

Oh, I’m a rabbit small and swift,
Hopping through code with a joyful lift.
Facility props are now out of sight,
Updates take the stage, shining bright.
With clean routes and links that flow,
My whiskers twitch in happy glow!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 96f04f8 and 2b589b5.

📒 Files selected for processing (1)
  • src/components/Facility/ConsultationDetails/QuestionnaireResponsesList.tsx (3 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Mar 7, 2025

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 2b589b5
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/67ca97817abba4000870cbc8
😎 Deploy Preview https://deploy-preview-11103.preview.ohc.network
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bodhish bodhish merged commit 2ef181d into ohcnetwork:develop Mar 7, 2025
12 of 14 checks passed
Copy link

github-actions bot commented Mar 7, 2025

@Jacobjeevan Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants