Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor layout fixes #11073

Merged
merged 2 commits into from
Mar 6, 2025
Merged

Conversation

Jacobjeevan
Copy link
Contributor

@Jacobjeevan Jacobjeevan commented Mar 6, 2025

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA in Mobile Devices
  • Completion of QA in Desktop Devices

Summary by CodeRabbit

Summary by CodeRabbit

  • Style
    • Enabled vertical scrolling in key content areas for smoother navigation.
    • Enhanced responsive layout with adjusted spacing and wrapping for improved display on various devices.
    • Refined component spacing by adding margins and modifying alignment for a more consistent interface presentation.
    • Removed horizontal centering from the ResourceDetails component for a different layout approach.

@Jacobjeevan Jacobjeevan requested a review from a team as a code owner March 6, 2025 08:32
Copy link
Contributor

coderabbitai bot commented Mar 6, 2025

Walkthrough

This pull request updates several UI components by modifying CSS class names to adjust scrolling behavior and layout. The changes add an overflow-y-auto class in key components to enable vertical scrolling and refine responsive design. Additionally, minor styling tweaks such as responsive gap adjustments, added margins, and the removal of horizontal centering have been applied. No functional or logical alterations were made.

Changes

File(s) Change Summary
src/Routers/AppRouter.tsx
src/components/Patient/.../EncounterQuestionnaire.tsx
src/components/Patient/.../PatientHome.tsx
Added overflow-y-auto class to allow vertical scrolling in the main content containers.
src/components/Questionnaire/QuestionTypes/.../DateTimeQuestion.tsx Modified class names to introduce responsive gap wrapping and conditional border styling for the input element.
src/components/Questionnaire/.../QuestionnaireForm.tsx Updated the DebugPreview component’s class to include a margin (m-2) for improved spacing.
src/components/Resource/.../ResourceDetails.tsx Removed the mx-auto class, eliminating automatic horizontal centering.

Possibly related PRs

Suggested labels

needs review, tested

Suggested reviewers

  • rithviknishad
  • khavinshankar

Poem

I’m a rabbit with a hop so light,
Dancing through code by day and night.
Scrolling smoothly with a little tweak,
Making overflow issues now oblique.
With every change, I cheer and sing,
Celebrating code like a bouncy spring!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 75e265b and c2f60d5.

📒 Files selected for processing (1)
  • src/components/Patient/PatientHome.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: Redirect rules - care-ohc
  • GitHub Check: Header rules - care-ohc
  • GitHub Check: Pages changed - care-ohc
  • GitHub Check: Test
  • GitHub Check: OSSAR-Scan
  • GitHub Check: cypress-run (1)
🔇 Additional comments (1)
src/components/Patient/PatientHome.tsx (1)

77-77: Good UI improvement for scrollable content.

Adding the overflow-y-auto class to the patient dashboard container ensures content that exceeds the viewport height becomes scrollable instead of being cut off or causing unwanted page expansion. This enhancement improves the user experience across different screen sizes and maintains content accessibility.

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Mar 6, 2025

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit c2f60d5
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/67c9614f2d18ed000823b4ab
😎 Deploy Preview https://deploy-preview-11073.preview.ohc.network
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jacobjeevan Jacobjeevan added needs testing needs review P1 breaking issue or vital feature and removed work-in-progress labels Mar 6, 2025
@rithviknishad rithviknishad requested a review from nihal467 March 6, 2025 09:18
@nihal467
Copy link
Member

nihal467 commented Mar 6, 2025

LGTM

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick pass lgtm

@rithviknishad rithviknishad merged commit 1dad7e2 into ohcnetwork:develop Mar 6, 2025
17 checks passed
Copy link

github-actions bot commented Mar 6, 2025

@Jacobjeevan Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

@coderabbitai coderabbitai bot mentioned this pull request Mar 7, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review P1 breaking issue or vital feature tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile Responsive issue : Encounter and Patients Page
3 participants