Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Unwanted Horizontal Scroll on Facility Settings Page #11045

Conversation

abhimanyurajeesh
Copy link
Contributor

@abhimanyurajeesh abhimanyurajeesh commented Mar 5, 2025

Proposed Changes

Screenshot

Before - > After
Screenshot 2025-03-05 at 5 30 12 PM Screenshot 2025-03-05 at 5 31 02 PM

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Summary by CodeRabbit

  • Style
    • Improved the appearance of the settings page by refining the tab alignment and spacing.
    • Enhanced responsiveness by adjusting element padding for a more balanced layout on both small and large screens.

@abhimanyurajeesh abhimanyurajeesh requested a review from a team as a code owner March 5, 2025 12:03
Copy link
Contributor

coderabbitai bot commented Mar 5, 2025

Walkthrough

The update refines the layout of the settings page by adjusting the alignment and spacing of tabs. The SettingsLayout now applies responsive classes to the tabs list and modifies the horizontal padding on the tab triggers for different screen sizes. These changes focus solely on the visual presentation without affecting the underlying functionality.

Changes

File(s) Summary
src/pages/Facility/.../layout.tsx Updated the TabsList class from justify-start to justify-evenly sm:justify-start and modified TabsTrigger padding from px-4 to px-2 on small screens.

Suggested labels

needs testing, needs review

Suggested reviewers

  • Jacobjeevan
  • rithviknishad

Poem

I'm a rabbit with a zestful hop,
Adjusting tabs that never stop.
With even spacing and padding light,
The settings page now feels just right.
I nibble on code and celebrate the tweak—
Hoppy changes making the interface sleek!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b519313 and e62244c.

📒 Files selected for processing (1)
  • src/pages/Facility/settings/layout.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: cypress-run (1)
🔇 Additional comments (3)
src/pages/Facility/settings/layout.tsx (3)

93-93: Good responsive layout improvement!

Changing from justify-start to justify-evenly sm:justify-start is a smart solution to eliminate horizontal scrolling on mobile screens. The evenly distributed tabs will make better use of the available space on smaller devices, while maintaining the original left-aligned layout on larger screens.


98-98: Appropriate padding adjustment for mobile devices

Reducing the horizontal padding from px-4 to px-2 on mobile screens while maintaining px-4 on larger screens is an effective way to prevent horizontal overflow. This change, combined with the justified layout above, should successfully fix the unwanted horizontal scroll issue mentioned in issue #11043.


91-107: Verify the fix on different mobile viewport sizes

The changes look good and should fix the horizontal scrolling issue. I recommend testing this fix across different mobile viewport sizes (especially very small screens like iPhone SE) to ensure the horizontal scroll is completely eliminated in all scenarios.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Mar 5, 2025

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit e62244c
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/67c83d783cf9230008d790e4
😎 Deploy Preview https://deploy-preview-11045.preview.ohc.network
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rithviknishad rithviknishad merged commit 2e7a84d into ohcnetwork:develop Mar 6, 2025
17 checks passed
Copy link

github-actions bot commented Mar 6, 2025

@abhimanyurajeesh Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Unwanted Horizontal Scroll on Facility Settings Page
2 participants