Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Medicine Administer List Should Only Show Active Medicines #10858

Merged
merged 2 commits into from
Feb 28, 2025
Merged

Medicine Administer List Should Only Show Active Medicines #10858

merged 2 commits into from
Feb 28, 2025

Conversation

AdityaJ2305
Copy link
Contributor

@AdityaJ2305 AdityaJ2305 commented Feb 27, 2025 •
edited by coderabbitai bot
Loading

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Summary by CodeRabbit

  • New Features
    • The medication administration interface now disables the "administer medicine" button when no active medications are available, providing immediate feedback.
    • The displayed list of medications is updated to show only currently active items for a more consistent user experience.

@AdityaJ2305 AdityaJ2305 requested a review from a team as a code owner February 27, 2025 18:34
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 27, 2025 •
edited
Loading

Walkthrough

The changes update the medication administration functionality. The "administer medicine" button is now disabled when there are no active medications, and the data passed to the MedicineAdminSheet component is updated to use the active medications (or an empty array if none exist). This aligns the component behavior with the current state of medication availability in the UI.

Changes

File(s) Change Summary
src/.../AdministrationTab.tsx - Added a disabled property to the "administer medicine" button, making it inactive when there are no active medications.
- Changed the medications prop for MedicineAdminSheet to use `activeMedications?.results

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant Tab as AdministrationTab
  participant Btn as "Administer Button"
  participant Sheet as MedicineAdminSheet

  User ->> Tab: Render view
  Tab ->> Btn: Set disabled = !activeMedications.length
  alt Active Medications Available
    User ->> Btn: Click "administer medicine"
    Btn ->> Sheet: Open with medications = activeMedications.results
  else No Active Medications
    User ->> Btn: Click attempt
    Btn -->> User: No action (button disabled)
  end
Loading

Possibly related PRs

Suggested labels

tested, reviewed

Suggested reviewers

  • rithviknishad
  • amjithtitus09

Poem

I'm a bunny coding with flair,
Hopping through changes with style to spare.
The button's quiet when meds aren't in sight,
Active meds lead the UI to light.
With each tweak, my heart skips a beat,
A joyful hop—this update is neat!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cf1292b and c40000f.

📒 Files selected for processing (1)
  • src/components/Medicine/MedicationAdministration/AdministrationTab.tsx (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: Redirect rules - care-ohc
  • GitHub Check: Header rules - care-ohc
  • GitHub Check: Pages changed - care-ohc
  • GitHub Check: Test
  • GitHub Check: OSSAR-Scan
  • GitHub Check: cypress-run (1)
🔇 Additional comments (2)
src/components/Medicine/MedicationAdministration/AdministrationTab.tsx (2)

799-799: Good UX improvement by disabling the medicine administration button

This change correctly disables the "administer medicine" button when there are no active medications available. This prevents users from clicking the button when no active medications can be administered, improving the user experience.

843-843: Correctly updated medication filtering implementation

The updated code now ensures that only active medications are passed to the MedicineAdminSheet component, regardless of the showStopped flag state. This aligns with the PR objective to only show active medicines in the administration list, and the fallback to an empty array is a good defensive practice.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify Netlify
Copy link

netlify bot commented Feb 27, 2025 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit bbb73ba
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/67c16430377229000852208b
😎 Deploy Preview https://deploy-preview-10858.preview.ohc.network
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amjithtitus09 amjithtitus09 merged commit e502bfb into ohcnetwork:develop Feb 28, 2025
6 of 7 checks passed
@github-actions GitHub Actions
Copy link

@AdityaJ2305 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

This was referenced Feb 28, 2025
Merged
Merged
ashwinpraveengo pushed a commit to ashwinpraveengo/care_fe that referenced this pull request Mar 2, 2025
@AdityaJ2305 @amjithtitus09 @ashwinpraveengo
Medicine Administer List Should Only Show Active Medicines (ohcnetwor…
89472f0 
…k#10858)

Co-authored-by: Amjith Titus <amjithtitus09@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amjithtitus09 amjithtitus09 amjithtitus09 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Medicine Administer List Should Only Show Active Medicines
2 participants
@AdityaJ2305 @amjithtitus09