Redirect on updating questionnaire #10796

Sulochan-khadka · 2025-02-24T10:58:24Z

Proposed Changes

Fixes Does not redirect on saving questionnaire #10784
Added navigation on updating

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

New Features
- Enhanced the update workflow by automatically redirecting users to the updated questionnaire’s page after a successful update, providing immediate feedback on their changes.

coderabbitai · 2025-02-24T10:58:35Z

Walkthrough

The changes update the onSuccess callback in the QuestionnaireEditor component by modifying its signature to accept a parameter of type QuestionnaireDetail. With this update, the callback utilizes the data.slug to navigate to the updated questionnaire's page upon a successful mutation. The error handling remains unchanged.

Changes

File Path	Change Summary
`src/components/Questionnaire/QuestionnaireEditor.tsx`	Updated `onSuccess` signature to accept a `data` parameter of type `QuestionnaireDetail` and added navigation using `data.slug` after a successful update.

Sequence Diagram(s)

sequenceDiagram
  participant QE as QuestionnaireEditor
  participant UQ as updateQuestionnaire Mutation
  participant Router as Navigation Service

  QE->>UQ: Trigger updateQuestionnaire()
  UQ-->>QE: Return QuestionnaireDetail data
  QE->>Router: navigate(`/admin/questionnaire/${data.slug}`)

Possibly related PRs

Appointments: redirect to patient page post update status to in_consultation #9672: Modifies the onSuccess callback in mutation functions, aligning navigation logic post-update.
Questionnaire list & create minor fixes #10747: Adjusts the QuestionnaireEditor component's callback for navigation enhancements using the update response.

Suggested labels

tested

Suggested reviewers

rithviknishad
Jacobjeevan

Poem

I'm a rabbit with a code delight,
Hopping through changes, day and night.
With a data leap and a navigational spree,
I guide the users, quick and free.
Cheers to updates that make our app so bright!
🐰✨

✨ Finishing Touches

📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-02-24T10:59:11Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`85c1cf7`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67bc50d57e2ac50008f99a34
😎 Deploy Preview	https://deploy-preview-10796.preview.ohc.network
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/components/Questionnaire/QuestionnaireEditor.tsx (1)
707-709: Enhance error handling for better debugging and user experience.

Consider improving the error handling by:

Logging the error details for debugging

Providing more specific error messages to users based on the error type

Implementing retry logic for transient failures
-    onError: (_error) => {
-      toast.error("Failed to update questionnaire");
-    },
+    onError: (error) => {
+      console.error("Failed to update questionnaire:", error);
+      const message = error.response?.data?.message || "Failed to update questionnaire";
+      toast.error(message, {
+        description: "Please try again or contact support if the issue persists",
+      });
+    },

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c269220 and 85c1cf7.

📒 Files selected for processing (1)

src/components/Questionnaire/QuestionnaireEditor.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (5)

GitHub Check: Redirect rules - care-ohc
GitHub Check: Header rules - care-ohc
GitHub Check: Pages changed - care-ohc
GitHub Check: cypress-run (1)
GitHub Check: OSSAR-Scan

🔇 Additional comments (2)

src/components/Questionnaire/QuestionnaireEditor.tsx (2)

702-705: LGTM! The navigation enhancement looks good.

The implementation correctly uses the questionnaire's slug from the response data to navigate to the updated questionnaire's page, providing immediate feedback after a successful update.

704-704: LGTM! Cache invalidation is properly implemented.

The cache invalidation correctly targets the specific questionnaire detail query, ensuring the UI stays in sync with the backend data.

github-actions · 2025-02-26T09:11:12Z

@Sulochan-khadka Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

redirect-on-updating-questionnaire

85c1cf7

Sulochan-khadka requested a review from a team as a code owner February 24, 2025 10:58

coderabbitai bot reviewed Feb 24, 2025

View reviewed changes

Jacobjeevan approved these changes Feb 25, 2025

View reviewed changes

Jacobjeevan added needs testing needs review labels Feb 25, 2025

Jacobjeevan changed the title ~~redirect-on-updating-questionnaire~~ Redirect on updating questionnaire Feb 26, 2025

Jacobjeevan added tested and removed needs testing needs review labels Feb 26, 2025

Jacobjeevan merged commit c097957 into ohcnetwork:develop Feb 26, 2025
17 checks passed

This was referenced Mar 3, 2025

Cancel button navigation issue in edit questionaire. #10954

Merged

Remove Questionnaire show usage #10962

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Redirect on updating questionnaire #10796

Redirect on updating questionnaire #10796

Sulochan-khadka commented Feb 24, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 24, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Feb 24, 2025 •

edited

Loading

coderabbitai bot left a comment

github-actions bot commented Feb 26, 2025

Redirect on updating questionnaire #10796

Redirect on updating questionnaire #10796

Conversation

Sulochan-khadka commented Feb 24, 2025 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Feb 24, 2025 • edited Loading

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Feb 24, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

coderabbitai bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 26, 2025

Sulochan-khadka commented Feb 24, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 24, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Feb 24, 2025 •

edited

Loading