Location Prefill with current location #10719

amjithtitus09 · 2025-02-20T11:00:30Z

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

New Features
- The location question now dynamically retrieves encounter details to display the current location.
- Updated logic ensures the association start time adopts the fetched encounter’s start date when available, or defaults to the current date otherwise.
Bug Fixes
- Improved handling of initial state for location selection based on fetched encounter data.

coderabbitai · 2025-02-20T11:00:39Z

Walkthrough

The changes update the LocationQuestion component by adding dynamic data fetching from an API using the @tanstack/react-query library. The component now uses the useQuery hook to retrieve encounter data based on encounterId and uses the fetched data to initialize the selectedLocation state. Additionally, the handleUpdateAssociation function has been modified to set the start_datetime from the encounter data if available, otherwise defaulting to the current date. Import statements have been updated accordingly.

Changes

File(s)	Change Summary
`src/components/.../LocationQuestion.tsx`	Introduced use of `@tanstack/react-query`'s `useQuery` hook to fetch encounter data; updated initialization of `selectedLocation` state; modified `handleUpdateAssociation` to set `start_datetime` based on fetched data; updated import statements.

Sequence Diagram(s)

sequenceDiagram
    participant LQ as LocationQuestion
    participant RQ as useQuery
    participant API as Encounter API
    LQ->>RQ: Initiate query using encounterId
    RQ->>API: Fetch encounter data
    API-->>RQ: Return encounter details (location, start_datetime)
    RQ-->>LQ: Provide encounter data
    LQ->>LQ: Update selectedLocation with fetched data
    Note over LQ: User triggers association update
    LQ->>LQ: Run handleUpdateAssociation (set start_datetime from data or current date)

Suggested labels

reviewed

Suggested reviewers

bodhish
rithviknishad

Poem

Hop, hop, through lines of code I skim,
Data fetched fresh, no longer dim.
With queries swift, I leap with glee,
Updating states as quick as can be!
Carrots and code—a perfect blend,
From my rabbit trail, cheers to the end! 🐰

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d98b9de and eb0e076.

📒 Files selected for processing (1)

src/components/Questionnaire/QuestionTypes/LocationQuestion.tsx (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/components/Questionnaire/QuestionTypes/LocationQuestion.tsx

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: cypress-run (1)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

cloudflare-workers-and-pages · 2025-02-20T11:01:04Z

Deploying care-fe with Cloudflare Pages

Latest commit:	`10706a9`
Status:	✅ Deploy successful!
Preview URL:	https://47312833.care-fe.pages.dev
Branch Preview URL:	https://location-minor-fix.care-fe.pages.dev

View logs

netlify · 2025-02-20T11:01:32Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`10706a9`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67b710ce0655d500089bce8b
😎 Deploy Preview	https://deploy-preview-10719.preview.ohc.network
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (1)

src/components/Questionnaire/QuestionTypes/LocationQuestion.tsx (1)
41-47: Consider adding error/loading fallback.
At present, there's no UI feedback for loading or error states. Incorporating optional loading and error handling leads to a better user experience and more resilient UI.

Below is an example diff illustrating how to handle loading and error states with React Query:
- const { data: encounter } = useQuery<Encounter>({
+ const { data: encounter, isLoading, isError } = useQuery<Encounter>({
   queryKey: ["encounter", encounterId],
   queryFn: query(api.encounter.get, {
     pathParams: { id: encounterId },
     queryParams: { facility: facilityId },
   }),
 });

+ if (isLoading) {
+   return <div>Loading encounter data...</div>;
+ }
+
+ if (isError) {
+   return <div>Failed to load encounter data.</div>;
+ }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 62b251b and d98b9de.

📒 Files selected for processing (1)

src/components/Questionnaire/QuestionTypes/LocationQuestion.tsx (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: cypress-run (1)

🔇 Additional comments (2)

src/components/Questionnaire/QuestionTypes/LocationQuestion.tsx (2)

1-1: No concerns with this new import.
The usage of @tanstack/react-query here looks appropriate.

9-11: Imports look good.
No issues identified with the newly introduced imports from api, query, or Encounter types.

src/components/Questionnaire/QuestionTypes/LocationQuestion.tsx

cypress · 2025-02-20T11:09:48Z

CARE Run #4896

Run Properties: Passed #4896 • eb0e0761c8: Location Prefill with current location

Project	`CARE`
Branch Review	`location-minor-fix`
Run status	`Passed #4896`
Run duration	`06m 38s`
Commit	`eb0e0761c8: Location Prefill with current location`
Committer	`Amjith Titus`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`11`
View all changes introduced in this branch ↗︎

github-actions · 2025-02-20T11:33:02Z

@amjithtitus09 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Location Prefill

d98b9de

amjithtitus09 requested a review from a team as a code owner February 20, 2025 11:00

coderabbitai bot reviewed Feb 20, 2025

View reviewed changes

src/components/Questionnaire/QuestionTypes/LocationQuestion.tsx Outdated Show resolved Hide resolved

amjithtitus09 added 2 commits February 20, 2025 16:47

Use useeffect instead

eb0e076

Merge branch 'develop' into location-minor-fix

10706a9

Jacobjeevan approved these changes Feb 20, 2025

View reviewed changes

amjithtitus09 merged commit 25e8186 into develop Feb 20, 2025
23 checks passed

amjithtitus09 deleted the location-minor-fix branch February 20, 2025 11:32

coderabbitai bot mentioned this pull request Feb 21, 2025

Location Availability display fix #10749

Merged

6 tasks

amjithtitus09 self-assigned this Feb 24, 2025

This was referenced Feb 26, 2025

Add Search Feature in Devices with name and location wise | Add Clear button in Location Search #10831

Open

SubQuestion | Pass in encounter Id #11032

Merged

coderabbitai bot mentioned this pull request Mar 8, 2025

Fix: Enhance LocationMap with interactive features and tooltips #11142

Open

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Location Prefill with current location #10719

Location Prefill with current location #10719

amjithtitus09 commented Feb 20, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 20, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

cloudflare-workers-and-pages bot commented Feb 20, 2025 •

edited

Loading

netlify bot commented Feb 20, 2025 •

edited

Loading

coderabbitai bot left a comment

cypress bot commented Feb 20, 2025 •

edited

Loading

github-actions bot commented Feb 20, 2025

Location Prefill with current location #10719

Location Prefill with current location #10719

Conversation

amjithtitus09 commented Feb 20, 2025 • edited by coderabbitai bot Loading

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Feb 20, 2025 • edited Loading

Walkthrough

Changes

Sequence Diagram(s)

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

cloudflare-workers-and-pages bot commented Feb 20, 2025 • edited Loading

Deploying care-fe with Cloudflare Pages

netlify bot commented Feb 20, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

coderabbitai bot left a comment

Choose a reason for hiding this comment

cypress bot commented Feb 20, 2025 • edited Loading

CARE Run #4896

github-actions bot commented Feb 20, 2025

amjithtitus09 commented Feb 20, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 20, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

cloudflare-workers-and-pages bot commented Feb 20, 2025 •

edited

Loading

netlify bot commented Feb 20, 2025 •

edited

Loading

cypress bot commented Feb 20, 2025 •

edited

Loading