Fix: Facility name update in facility switcher #10665

Rishith25 · 2025-02-18T05:48:43Z

Proposed Changes

Fixes Bug : Facility name is not updating in Facility switcher #10664

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

New Features
- Facility updates now automatically refresh your user data, ensuring that any changes affecting your account information or permissions are promptly reflected for a more consistent experience.

coderabbitai · 2025-02-18T05:48:51Z

Walkthrough

The pull request introduces a new query invalidation in the FacilityForm.tsx file. Specifically, after a successful update via the updateFacility mutation, an additional invalidation for the currentUser key is executed alongside existing invalidations for organizationFacilities and facility. This change ensures that the current user’s data remains current when facility updates occur.

Changes

File	Summary of Changes
`src/components/Facility/FacilityForm.tsx`	Added query invalidation for the `currentUser` key in the `onSuccess` callback of the `updateFacility` mutation.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant F as FacilityForm Component
    participant M as updateFacility Mutation
    participant Q as Query Manager

    U->>F: Trigger update facility action
    F->>M: Call updateFacility mutation
    M-->>F: Mutation success response
    F->>Q: Invalidate `organizationFacilities` query
    F->>Q: Invalidate `facility` query
    F->>Q: Invalidate `currentUser` query
    Q-->>F: Refresh data

Possibly related PRs

Fix: FacilityData not populating on Edit #10077: Addresses similar invalidation logic in FacilityForm.tsx focusing on facility data; may relate to the addition of the currentUser invalidation.

Suggested labels

needs review, tested

Suggested reviewers

rithviknishad
Jacobjeevan

Poem

I'm a bouncy little rabbit,
Hopping through code with glee,
Updating queries with each tap,
Now currentUser's fresh as can be!
Cheers to clear data, 🐰💻
In a garden of components, dancing free!

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

…evelop

netlify · 2025-02-18T05:51:25Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`7b78a29`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67b4240315c87800086ac41b
😎 Deploy Preview	https://deploy-preview-10665.preview.ohc.network
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/components/Facility/FacilityForm.tsx (1)

109-117: Consider batching query invalidations for better performance.

The multiple invalidateQueries calls could be combined into a single call to reduce the number of React Query cache updates.

-      queryClient.invalidateQueries({
-        queryKey: ["organizationFacilities"],
-      });
-      queryClient.invalidateQueries({
-        queryKey: ["facility"],
-      });
-      queryClient.invalidateQueries({
-        queryKey: ["currentUser"],
-      });
+      queryClient.invalidateQueries({
+        queryKey: [
+          ["organizationFacilities"],
+          ["facility"],
+          ["currentUser"]
+        ]
+      });

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 092aae6 and 7734e89.

📒 Files selected for processing (1)

src/components/Facility/FacilityForm.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (8)

GitHub Check: Redirect rules - care-ohc
GitHub Check: Header rules - care-ohc
GitHub Check: Pages changed - care-ohc
GitHub Check: Test
GitHub Check: lint
GitHub Check: CodeQL-Build
GitHub Check: cypress-run (1)
GitHub Check: OSSAR-Scan

🔇 Additional comments (1)

src/components/Facility/FacilityForm.tsx (1)

115-117: LGTM! Good addition of currentUser invalidation.

The addition of currentUser query invalidation ensures that the user's context remains in sync after facility updates, which is essential for the facility switcher to display the correct facility name.

github-actions · 2025-02-18T06:32:10Z

@Rishith25 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Rishith25 added 5 commits February 16, 2025 17:56

selected Facility state changed to null

4ba8831

Merge branch 'develop' of github.com:ohcnetwork/care_fe into develop

39fbd97

Merge branch 'develop' of github.com:ohcnetwork/care_fe into develop

5c7db7e

Merge branch 'develop' of github.com:ohcnetwork/care_fe into develop

e88964f

Invalidate currentUser query on facility form submission

79d98f8

Rishith25 requested a review from a team as a code owner February 18, 2025 05:48

Merge branch 'develop' of https://github.com/Rishith25/care_fe into d…

ac1f7ed

…evelop

Merge branch 'develop' into facility-switcher-name-update

7734e89

coderabbitai bot reviewed Feb 18, 2025

View reviewed changes

Merge branch 'develop' into facility-switcher-name-update

7b78a29

rithviknishad approved these changes Feb 18, 2025

View reviewed changes

rithviknishad merged commit f3359ea into ohcnetwork:develop Feb 18, 2025
14 of 15 checks passed

rithviknishad added the tested label Feb 18, 2025

coderabbitai bot mentioned this pull request Feb 27, 2025

Add Search Feature in Devices with name and location wise | Add Clear button in Location Search #10831

Open

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Facility name update in facility switcher #10665

Fix: Facility name update in facility switcher #10665

Rishith25 commented Feb 18, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 18, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Feb 18, 2025 •

edited

Loading

coderabbitai bot left a comment

github-actions bot commented Feb 18, 2025

Fix: Facility name update in facility switcher #10665

Fix: Facility name update in facility switcher #10665

Conversation

Rishith25 commented Feb 18, 2025 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Feb 18, 2025 • edited Loading

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Feb 18, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

coderabbitai bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 18, 2025

Rishith25 commented Feb 18, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 18, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Feb 18, 2025 •

edited

Loading