Fix Button Overflow and Minor Responsive Issues on Mobile View #10546

modamaan · 2025-02-10T15:14:36Z

Proposed Changes

change 2

change 3

change 4

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

New Features
- Introduced updated localization strings, including a new entry for full-day unavailability and differentiated questionnaire labels.
Style
- Enhanced responsive layouts for search popovers, form buttons, and availability tabs.
- Updated headings and navigation labels to reflect the new text entries.
Chores
- Refined locale files for consistency and resolved formatting discrepancies in specific languages.

coderabbitai · 2025-02-10T15:14:46Z

Walkthrough

The pull request updates several localization files and UI components. In the locale JSON files, it adds a new key and splits an existing questionnaire key into two separate keys, while also modifying JSON formatting and removing an unused key. In the UI components, various CSS class names are adjusted to improve responsiveness and styling. Additionally, a few components now reference the updated localization keys by using the translation function instead of hardcoded strings.

Changes

File(s)	Change Summary
`public/locale/en.json`, `public/locale/hi.json`, `public/locale/ml.json`	en.json: Added `"full_day_unavailable": "Full Day Unavailable"` and split `"questionnaire"` into `"questionnaire_one": "Questionnaire"` and `"questionnaire_other": "Questionnaires"`; hi.json: Removed a trailing closing brace; ml.json: Removed the `"questionnaire"` translation.
`src/components/Questionnaire/QuestionnaireSearch.tsx`, `src/pages/Patients/VerifyPatient.tsx`, `src/components/Users/UserAvailabilityTab.tsx`	Updated CSS classes for responsive layout: Changed fixed width to responsive in `QuestionnaireSearch`, adjusted a button wrapper to full width in `VerifyPatient`, and modified spacing/padding classes in `UserAvailabilityTab`.
`src/pages/Scheduling/components/CreateScheduleExceptionSheet.tsx`, `src/components/Patient/EncounterQuestionnaire.tsx`, `src/components/Questionnaire/QuestionnaireList.tsx`, `src/components/ui/sidebar/admin-nav.tsx`	Replaced hardcoded text with translation functions: Updated form labels in the schedule exception sheet and switched localization keys from `"questionnaire"` to `"questionnaire_one"`/`"questionnaire_other"` in various components.

Possibly related PRs

Rewamp UX for symptoms and diagnosis in EncounterQuestionnaire #9644: Modifies localization keys for questionnaires, aligning with the new "questionnaire_one" and "questionnaire_other" keys.
Fix : Date field overflow in exception form in mobile view #10112: Updates the EncounterQuestionnaire component to use the new localization key, directly relating to this PR's changes.
Add missing i18n translations #10463: Involves modifications to localization JSON entries, similar to the adjustments introduced here.

Suggested labels

tested, needs-triage

Suggested reviewers

Jacobjeevan
rithviknishad

Poem

I'm a bunny hopping through code delight,
Skipping through keys both day and night.
I nibble on changes, crisp and new,
With updated styles and translations too.
In each line of code, I find a treat –
A joyful hop in every beat!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 66acf9b and 34e7f6c.

📒 Files selected for processing (3)

public/locale/en.json (2 hunks)
public/locale/ml.json (0 hunks)
src/components/Questionnaire/QuestionnaireList.tsx (1 hunks)

💤 Files with no reviewable changes (1)

public/locale/ml.json

🚧 Files skipped from review as they are similar to previous changes (2)

src/components/Questionnaire/QuestionnaireList.tsx
public/locale/en.json

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: Test
GitHub Check: cypress-run (1)
GitHub Check: OSSAR-Scan

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-02-10T15:15:06Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`3e057a7`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67c6907656001200084ca935
😎 Deploy Preview	https://deploy-preview-10546.preview.ohc.network
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

…or-responsive

…damaan/care_feAmaan into issues/10524/minor-responsive

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/components/Questionnaire/QuestionnaireSearch.tsx (1)
96-96: Consider adjusting max-height for better mobile experience.

The fixed max-h-[400px] might be too tall for mobile screens, especially when the keyboard is open. Consider using a responsive max-height:
-<div className="max-h-[400px] overflow-y-auto p-0">
+<div className="max-h-[300px] sm:max-h-[400px] overflow-y-auto p-0">

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4588408 and 47d0e80.

📒 Files selected for processing (4)

public/locale/en.json (4 hunks)
src/components/Questionnaire/QuestionnaireSearch.tsx (1 hunks)
src/pages/Patients/VerifyPatient.tsx (1 hunks)
src/pages/Scheduling/components/CreateScheduleExceptionSheet.tsx (2 hunks)

✅ Files skipped from review due to trivial changes (1)

src/pages/Scheduling/components/CreateScheduleExceptionSheet.tsx

🚧 Files skipped from review as they are similar to previous changes (1)

public/locale/en.json

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: cypress-run (1)

🔇 Additional comments (2)

src/components/Questionnaire/QuestionnaireSearch.tsx (1)

83-83: Great responsive design implementation!

The change from a fixed width to a responsive width using w-full sm:w-[600px] effectively addresses the mobile view issues while maintaining the desktop experience. This is a solid implementation of mobile-first responsive design.

src/pages/Patients/VerifyPatient.tsx (1)

167-167: LGTM! Effective fix for button overflow.

Adding w-full to the container div ensures proper content alignment and prevents overflow issues on mobile view. The change maintains consistency with the existing responsive design patterns.

src/components/Questionnaire/QuestionnaireSearch.tsx

public/locale/en.json

…or-responsive

Jacobjeevan

Let's adjust this as well

public/locale/en.json

github-actions · 2025-02-27T12:45:22Z

Conflicts have been detected against the base branch. Please merge the base branch into your branch.
cc: @modamaan

See: https://docs.ohc.network/docs/contributing#how-to-resolve-merge-conflicts

…or-responsive

github-actions · 2025-03-03T04:12:23Z

Conflicts have been detected against the base branch. Please merge the base branch into your branch.
cc: @modamaan

See: https://docs.ohc.network/docs/contributing#how-to-resolve-merge-conflicts

khavinshankar · 2025-03-03T06:26:07Z

@modamaan clear the merge conflicts

nihal467 · 2025-03-04T05:44:30Z

LGTM

github-actions · 2025-03-04T11:56:12Z

@modamaan Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

…twork#10546)

modamaan added 2 commits February 10, 2025 20:38

userDashboard page button overflow solved

19c9e9c

translation added

4588408

modamaan requested a review from a team as a code owner February 10, 2025 15:14

modamaan marked this pull request as draft February 10, 2025 15:14

modamaan and others added 8 commits February 10, 2025 20:54

Merge remote-tracking branch 'upstream/develop' into issues/10524/min…

01e947c

…or-responsive

Merge branch 'develop' into issues/10524/minor-responsive

2326db1

questionnaire popover width adjusted

dd68f65

Merge branch 'issues/10524/minor-responsive' of https://github.com/mo…

28e3f9f

…damaan/care_feAmaan into issues/10524/minor-responsive

Merge branch 'develop' into issues/10524/minor-responsive

f1906fa

arrow position updated

577ea9c

Merge branch 'issues/10524/minor-responsive' of https://github.com/mo…

e22af3c

…damaan/care_feAmaan into issues/10524/minor-responsive

datepicker width updated

47d0e80

modamaan marked this pull request as ready for review February 11, 2025 01:04

coderabbitai bot reviewed Feb 11, 2025

View reviewed changes

translation added

c3d29fa

rithviknishad requested changes Feb 11, 2025

View reviewed changes

src/components/Questionnaire/QuestionnaireSearch.tsx Outdated Show resolved Hide resolved

public/locale/en.json Outdated Show resolved Hide resolved

rithviknishad added the changes required label Feb 11, 2025

AdityaJ2305 reviewed Feb 11, 2025

View reviewed changes

public/locale/en.json Outdated Show resolved Hide resolved

modamaan and others added 4 commits February 11, 2025 18:10

input green border removed

e425125

Merge remote-tracking branch 'upstream/develop' into issues/10524/min…

2b0e659

…or-responsive

translation updated

4834acb

Merge branch 'develop' into issues/10524/minor-responsive

2ca6cc2

modamaan requested review from AdityaJ2305 and rithviknishad February 11, 2025 13:03

Jacobjeevan requested changes Feb 12, 2025

View reviewed changes

public/locale/en.json Outdated Show resolved Hide resolved

Jacobjeevan removed the request for review from AdityaJ2305 February 12, 2025 11:37

modamaan added 2 commits February 12, 2025 20:40

translation Singular / Plural updated based on documentation

88fbdd8

translation updated on all language files

5e52c04

github-actions bot added the merge conflict pull requests with merge conflict label Feb 27, 2025

modamaan added 2 commits February 28, 2025 07:23

Merge remote-tracking branch 'upstream/develop' into issues/10524/min…

64633e8

…or-responsive

translater updated

66acf9b

github-actions bot removed the merge conflict pull requests with merge conflict label Feb 28, 2025

Jacobjeevan approved these changes Feb 28, 2025

View reviewed changes

Jacobjeevan added the needs testing label Feb 28, 2025

Jacobjeevan removed their assignment Feb 28, 2025

github-actions bot added the merge conflict pull requests with merge conflict label Mar 3, 2025

khavinshankar approved these changes Mar 3, 2025

View reviewed changes

merge conflic removed

34e7f6c

modamaan requested review from khavinshankar and rithviknishad March 3, 2025 14:24

github-actions bot removed the merge conflict pull requests with merge conflict label Mar 3, 2025

Merge branch 'develop' into issues/10524/minor-responsive

3e057a7

nihal467 added tested and removed needs testing labels Mar 4, 2025

khavinshankar approved these changes Mar 4, 2025

View reviewed changes

khavinshankar merged commit 295ebee into ohcnetwork:develop Mar 4, 2025
17 checks passed

coderabbitai bot mentioned this pull request Mar 4, 2025

Questionnaire preview redesign #10928

Open

6 tasks

Spandan-Mishra pushed a commit to Spandan-Mishra/ohcare_fe that referenced this pull request Mar 5, 2025

Fix Button Overflow and Minor Responsive Issues on Mobile View (ohcne…

aacc26b

…twork#10546)

Vikaspal8923 pushed a commit to Vikaspal8923/care_fe that referenced this pull request Mar 6, 2025

Fix Button Overflow and Minor Responsive Issues on Mobile View (ohcne…

02114f4

…twork#10546)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Button Overflow and Minor Responsive Issues on Mobile View #10546

Fix Button Overflow and Minor Responsive Issues on Mobile View #10546

modamaan commented Feb 10, 2025 •

edited

Loading

coderabbitai bot commented Feb 10, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Feb 10, 2025 •

edited

Loading

coderabbitai bot left a comment

Jacobjeevan left a comment

github-actions bot commented Feb 27, 2025

github-actions bot commented Mar 3, 2025

khavinshankar commented Mar 3, 2025

nihal467 commented Mar 4, 2025

github-actions bot commented Mar 4, 2025

Fix Button Overflow and Minor Responsive Issues on Mobile View #10546

Fix Button Overflow and Minor Responsive Issues on Mobile View #10546

Conversation

modamaan commented Feb 10, 2025 • edited Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Feb 10, 2025 • edited Loading

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Feb 10, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Jacobjeevan left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 27, 2025

github-actions bot commented Mar 3, 2025

khavinshankar commented Mar 3, 2025

nihal467 commented Mar 4, 2025

github-actions bot commented Mar 4, 2025

modamaan commented Feb 10, 2025 •

edited

Loading

coderabbitai bot commented Feb 10, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Feb 10, 2025 •

edited

Loading