Questionnaire Response List | Display multi values #10448

amjithtitus09 · 2025-02-06T12:40:54Z

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

New Features
- Questionnaire responses now display all provided values, offering a more comprehensive view.
- Improved layout presents response details with better spacing and contextual placement of notes for enhanced clarity.

coderabbitai · 2025-02-06T12:41:02Z

Walkthrough

The pull request updates the QuestionResponseValue component within the QuestionnaireResponsesList.tsx file. The rendering logic now iterates over the entire response.values array, displaying multiple values rather than a single one. Additionally, the response note is rendered after the last value inside a new wrapper div with improved spacing. No changes were made to public entities or exported declarations.

Changes

File	Change Summary
src/components/Facility/.../QuestionnaireResponsesList.tsx	Modified the `QuestionResponseValue` component: replaced single value extraction with iteration over `response.values` and adjusted note placement.

Sequence Diagram(s)

sequenceDiagram
    participant Component as QuestionResponseValue
    participant Renderer as UI Renderer
    participant Values as response.values

    Component->>Values: Retrieve all valueObj elements
    loop For each valueObj
        Values-->>Component: Return value / value_quantity if exists
        Component->>Renderer: Render individual value
    end
    Component->>Renderer: Render response note after last value

Possibly related PRs

Render multi line text in Questionnaire Response #10216 – Alters the rendering logic of the same QuestionResponseValue component by modifying the class name of a <div> element, indicating a strong connection to these changes.

Suggested labels

tested, reviewed

Suggested reviewers

rithviknishad
Jacobjeevan

Poem

I'm a rabbit hopping through the code,
Where multiple answers now brightly explode.
Each value leaps in joyful display,
With a note that comes at the end of the day.
Carrots and code, in a merry parade!
Happy hops in every update made.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-02-06T12:41:14Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`9786191`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67a4ae5089a2cc00082adf2b
😎 Deploy Preview	https://deploy-preview-10448--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cloudflare-workers-and-pages · 2025-02-06T12:41:44Z

Deploying care-fe with Cloudflare Pages

Latest commit:	`9786191`
Status:	✅ Deploy successful!
Preview URL:	https://a669eb8e.care-fe.pages.dev
Branch Preview URL:	https://questionnaire-response-view.care-fe.pages.dev

View logs

…questionnaire-response-view

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/components/Facility/ConsultationDetails/QuestionnaireResponsesList.tsx (1)
75-97: LGTM! Improved handling of multiple response values.

The changes effectively handle multiple response values with proper spacing and conditional rendering of units and notes.

Consider adding error handling and accessibility improvements.

A few suggestions to enhance robustness and accessibility:

Add error boundary for malformed response data

Add ARIA labels for screen readers

Consider adding an empty state message when no valid values exist

Here's how you could implement these improvements:
 <div className="space-y-1">
+  {response.values.length === 0 && (
+    <div className="text-sm text-gray-500">No response values</div>
+  )}
   {response.values.map((valueObj, index) => {
     const value = valueObj.value || valueObj.value_quantity?.value;
     if (!value) return null;

     return (
       <div
         key={index}
         className="text-sm font-medium whitespace-pre-wrap"
+        role="group"
+        aria-label={`Response value ${index + 1} of ${response.values.length}`}
       >
         {formatValue(value, question.type)}
         {question.unit?.code && (
-          <span className="ml-1 text-xs">{question.unit.code}</span>
+          <span className="ml-1 text-xs" aria-label="unit">{question.unit.code}</span>
         )}
         {index === response.values.length - 1 && response.note && (
-          <span className="ml-2 text-xs text-gray-500">
+          <span className="ml-2 text-xs text-gray-500" aria-label="note">
             ({response.note})
           </span>
         )}
       </div>
     );
   })}
 </div>

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 662f462 and 9786191.

📒 Files selected for processing (1)

src/components/Facility/ConsultationDetails/QuestionnaireResponsesList.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: cypress-run (1)
GitHub Check: OSSAR-Scan

🔇 Additional comments (2)

src/components/Facility/ConsultationDetails/QuestionnaireResponsesList.tsx (2)

158-162: LGTM! Clean integration with parent components.

The changes to handle multiple values integrate seamlessly with both usage locations in the QuestionGroup component and the main questionnaire response rendering.

Also applies to: 255-259

69-100: LGTM! Successfully implemented multi-value display.

The changes effectively fulfill the PR objective of displaying multiple questionnaire response values while maintaining clean code structure and handling edge cases appropriately.

cypress · 2025-02-06T12:49:37Z

CARE Run #4676

Run Properties: Passed #4676 • 97861917e2: Questionnaire Response List | Display multi values

Project	`CARE`
Branch Review	`questionnaire-response-view`
Run status	`Passed #4676`
Run duration	`06m 36s`
Commit	`97861917e2: Questionnaire Response List \| Display multi values`
Committer	`Amjith Titus`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`11`
View all changes introduced in this branch ↗︎

nihal467 · 2025-02-06T13:20:11Z

LGTM

nihal467 · 2025-02-06T13:22:39Z

LGTM

src/components/Facility/ConsultationDetails/QuestionnaireResponsesList.tsx

github-actions · 2025-02-06T13:44:44Z

@amjithtitus09 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Questionnaire Response | Display multi values

65a09f6

amjithtitus09 requested a review from a team as a code owner February 6, 2025 12:40

Merge branch 'develop' of https://github.com/ohcnetwork/care_fe into …

9786191

…questionnaire-response-view

coderabbitai bot reviewed Feb 6, 2025

View reviewed changes

nihal467 added tested needs review labels Feb 6, 2025

rithviknishad approved these changes Feb 6, 2025

View reviewed changes

rithviknishad reviewed Feb 6, 2025

View reviewed changes

src/components/Facility/ConsultationDetails/QuestionnaireResponsesList.tsx Show resolved Hide resolved

rithviknishad merged commit 87f70f4 into develop Feb 6, 2025
23 checks passed

rithviknishad deleted the questionnaire-response-view branch February 6, 2025 13:44

coderabbitai bot mentioned this pull request Feb 12, 2025

Add pagination for questionaires #10575

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Questionnaire Response List | Display multi values #10448

Questionnaire Response List | Display multi values #10448

amjithtitus09 commented Feb 6, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 6, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Feb 6, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Feb 6, 2025 •

edited

Loading

coderabbitai bot left a comment

cypress bot commented Feb 6, 2025 •

edited

Loading

nihal467 commented Feb 6, 2025

nihal467 commented Feb 6, 2025

github-actions bot commented Feb 6, 2025

Questionnaire Response List | Display multi values #10448

Questionnaire Response List | Display multi values #10448

Conversation

amjithtitus09 commented Feb 6, 2025 • edited by coderabbitai bot Loading

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Feb 6, 2025 • edited Loading

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Feb 6, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

cloudflare-workers-and-pages bot commented Feb 6, 2025 • edited Loading

Deploying care-fe with Cloudflare Pages

coderabbitai bot left a comment

Choose a reason for hiding this comment

cypress bot commented Feb 6, 2025 • edited Loading

CARE Run #4676

nihal467 commented Feb 6, 2025

nihal467 commented Feb 6, 2025

github-actions bot commented Feb 6, 2025

amjithtitus09 commented Feb 6, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 6, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Feb 6, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Feb 6, 2025 •

edited

Loading

cypress bot commented Feb 6, 2025 •

edited

Loading