Staging Patch: Fix setting time on datetime question causing duplicates #10370

rithviknishad · 2025-02-03T11:34:28Z

Staging Patch of: #10369

Summary by CodeRabbit

Bug Fixes
- Updated date/time input handling so that only the latest selection is recorded, ensuring your responses reflect the most recent update.
Documentation
- Enhanced configuration notes for plugin integrations to provide clearer guidance.

coderabbitai · 2025-02-03T11:34:38Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This pull request makes two main changes. In the DateTimeQuestion component, the handleTimeChange function has been modified to remove the merging of previous response values, resulting in only an updated date/time value being sent. Additionally, a comment in the entry point file has been updated to clarify that the CARE_API_URL is exposed on the global window object for plugin usage. No changes were made to the public API of either component.

Changes

File(s)	Change Summary
`src/components/Questionnaire/.../DateTimeQuestion.tsx`	Modified `handleTimeChange`: removed spreading of previous values, so the update now sends only a new object with the updated date/time, causing previous values to be lost.
`src/index.tsx`	Updated comment for the `CARE_API_URL` assignment, now clarifying its exposure to the global `window` object for plugin usage.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant D as DateTimeQuestion
    participant CB as updateQuestionnaireResponseCB
    U->>D: Trigger Time Change Event
    D->>CB: Invoke update with new date/time (no previous values)

Suggested Reviewers

Jacobjeevan

Poem

I'm a bouncy bunny, hoppin' by,
Changing code with a keen, sharp eye,
Old values vanish, new times appear,
In the realm of code, my hops are sincere,
Leaping forward with a digital cheer!
🥕🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-02-03T11:34:47Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`e44be02`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67a0a9c8302e34000803dabb
😎 Deploy Preview	https://deploy-preview-10370--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cloudflare-workers-and-pages · 2025-02-03T11:36:03Z

Deploying care-fe with Cloudflare Pages

Latest commit:	`b132ee7`
Status:	✅ Deploy successful!
Preview URL:	https://6d297004.care-fe.pages.dev
Branch Preview URL:	https://rithviknishad-staging-patch.care-fe.pages.dev

View logs

cypress · 2025-02-03T11:42:07Z

CARE Run #4579

Run Properties: Passed #4579 • e44be02631: Rithviknishad/staging patch/datetime question causing duplicates

Project	`CARE`
Branch Review	`rithviknishad/staging-patch/datetime-question-causing-duplicates`
Run status	`Passed #4579`
Run duration	`05m 59s`
Commit	`e44be02631: Rithviknishad/staging patch/datetime question causing duplicates`
Committer	`Rithvik Nishad`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`10`
View all changes introduced in this branch ↗︎

nihal467 · 2025-02-03T11:47:16Z

LGTM

github-actions · 2025-02-03T11:50:42Z

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

* Fix Content-type header in Scribe.tsx (#7631) (#7634) Co-authored-by: Ashesh <3626859+Ashesh3@users.noreply.github.com> * Merge develop to staging v24.16.0 (#7667) * flaky test (#7657) * Fix round type display and qr field (#7666) * Revert "Merge develop to staging v24.16.0 (#7667)" (#7669) This reverts commit a91230a. * Fixes neurological tab from crashing in older browsers (patch to `staging`) * Sainak/fix/pdf-worker-mime-type (#8513) * Fixes file upload missing pagination component * Plausible: Track applied filters (#8641) * disable abha number linking when health facility id is not present * Revert "disable abha number linking when health facility id is not present" This reverts commit 63a28a5. * include icons used in enabled apps while treeshaking the icons * Fix min date for discharge (#9082) * replicated the PR 9139 * User creation form bug fix (#9406) * fixed critical care update redirection * expose env variables to plugins via window * Staging Patch: Fix setting time on datetime question causing duplicates (#10370) * remove hardcoded date encounter notes (#10382) * added PatientDetailsTabDemographyGeneralInfo plaggable (#10417) * Staging Patch: Remove appointment type section from patient details page (#10432) --------- Co-authored-by: Gigin George <mail.gigin@gmail.com> Co-authored-by: Mohammed Nihal <57055998+nihal467@users.noreply.github.com> Co-authored-by: Ashesh <3626859+Ashesh3@users.noreply.github.com> Co-authored-by: Khavin Shankar <khavinshankar@gmail.com> Co-authored-by: Vignesh Hari <vichuhari100@gmail.com> Co-authored-by: Aakash Singh <mail@singhaakash.dev> Co-authored-by: Shivank Kacker <kacker.shivank@gmail.com> Co-authored-by: Jacob John Jeevan <40040905+Jacobjeevan@users.noreply.github.com>

Fix: Remove redundant spread of previous values in DateTimeQuestion

e44be02

rithviknishad requested a review from a team as a code owner February 3, 2025 11:34

rithviknishad changed the base branch from develop to staging February 3, 2025 11:34

rithviknishad changed the title ~~Rithviknishad/staging patch/datetime question causing duplicates~~ Staging Patch: Fix setting time on datetime question causing duplicates Feb 3, 2025

ensure values are formatted in Observation List

b132ee7

nihal467 added the tested label Feb 3, 2025

khavinshankar approved these changes Feb 3, 2025

View reviewed changes

khavinshankar merged commit 4ae9cae into staging Feb 3, 2025
13 of 15 checks passed

khavinshankar deleted the rithviknishad/staging-patch/datetime-question-causing-duplicates branch February 3, 2025 11:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Staging Patch: Fix setting time on datetime question causing duplicates #10370

Staging Patch: Fix setting time on datetime question causing duplicates #10370

rithviknishad commented Feb 3, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 3, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Feb 3, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Feb 3, 2025 •

edited

Loading

cypress bot commented Feb 3, 2025

nihal467 commented Feb 3, 2025

github-actions bot commented Feb 3, 2025

Staging Patch: Fix setting time on datetime question causing duplicates #10370

Staging Patch: Fix setting time on datetime question causing duplicates #10370

Conversation

rithviknishad commented Feb 3, 2025 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Feb 3, 2025 • edited Loading

Review skipped

Walkthrough

Changes

Sequence Diagram(s)

Suggested Reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Feb 3, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

cloudflare-workers-and-pages bot commented Feb 3, 2025 • edited Loading

Deploying care-fe with Cloudflare Pages

cypress bot commented Feb 3, 2025

CARE Run #4579

nihal467 commented Feb 3, 2025

github-actions bot commented Feb 3, 2025

rithviknishad commented Feb 3, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 3, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Feb 3, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Feb 3, 2025 •

edited

Loading