Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Practitioner Selection in Book Appointment Page #10236

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jan 28, 2025

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Summary by CodeRabbit

  • Localization

    • Added a new localization key for displaying "No practitioners found" message
  • User Experience

    • Enhanced appointment booking flow with automatic resource selection
    • Improved user feedback when no practitioners are available
    • Updated placeholder text for practitioner selection

@rithviknishad rithviknishad requested a review from a team as a code owner January 28, 2025 11:00
Copy link
Contributor

coderabbitai bot commented Jan 28, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces a new localization entry for "No practitioners found" in the English JSON file and modifies the BookAppointment component to handle scenarios with zero or single practitioners. The changes improve user experience by providing clear feedback when no practitioners are available and automatically selecting the resource when only one practitioner exists.

Changes

File Change Summary
public/locale/en.json Added new localization key "no_practitioners_found" with value "No practitioners found"
src/pages/Appointments/BookAppointment.tsx Updated useEffect to handle single practitioner scenario and added error toast for no practitioners

Assessment against linked issues

Objective Addressed Explanation
Remove "Show all" default selection Unclear if fully addressed; placeholder changed but default selection behavior not completely resolved
Show all user's available slots Partial implementation; needs further investigation
Handle no practitioner scenario Added error toast and localization for no practitioners found

Possibly related PRs

Suggested labels

needs review, tested

Suggested reviewers

  • Jacobjeevan

Poem

🐰 In the realm of code, where rabbits hop with glee,
No practitioners found? Fear not, our UI will set you free!
A message clear, a toast so bright,
Guiding users through the digital light!
Localization magic, with just a line or two,
Making appointments smooth, just for you! 🌈


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b476406 and fe839c9.

📒 Files selected for processing (2)
  • public/locale/en.json (1 hunks)
  • src/pages/Appointments/BookAppointment.tsx (3 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit fe839c9
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/6798b8cd5fd73c0008c27594
😎 Deploy Preview https://deploy-preview-10236--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: fe839c9
Status: ✅  Deploy successful!
Preview URL: https://00642c1f.care-fe.pages.dev
Branch Preview URL: https://rithviknishad-fix-book-appoi.care-fe.pages.dev

View logs

@khavinshankar khavinshankar merged commit c0197cd into develop Jan 28, 2025
17 of 18 checks passed
@khavinshankar khavinshankar deleted the rithviknishad/fix/book-appointment-practicioner-selector branch January 28, 2025 11:02
Copy link

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Show all" default selection in appointments is not fetching all users appointments
2 participants