-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to using shadcn's Sonner for in-app toast notifications #9394
Comments
May I work on this issue? |
@nilay-v3rma could you open a draft PR once you start working on it? |
@rithviknishad sure i'll raise it asap |
@rithviknishad I have raised the PR |
@rithviknishad Can you please assign this work to me
@rithviknishad I would to like to solve this, Could you please assign this task to me? |
Currently, notifications are dispatched via functions exported from Notifications.js.
Since we are slowly moving towards using shadcn's UI components, let's switch to using shadcn's sonner for notifications.
https://ui.shadcn.com/docs/components/sonner
Here's an example of the Toaster component added to the
App.tsx
file (to ensure colours are as expected).care_fe/src/App.tsx
Lines 38 to 45 in e48d37c
Here's the full attempt diff for reference: https://github.com/ohcnetwork/care_fe/pull/9350/files
Action Items
toast
of sonner instead of frompnotify
library.pnotify
and related packages.The text was updated successfully, but these errors were encountered: