Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

404 Not found errors on district and local bodies in Advanced Filters #7005

Closed
rithviknishad opened this issue Jan 11, 2024 · 1 comment · Fixed by #7006
Closed

404 Not found errors on district and local bodies in Advanced Filters #7005

rithviknishad opened this issue Jan 11, 2024 · 1 comment · Fixed by #7006
Assignees
@rithviknishad
Labels
bug Something isn't working P1 breaking issue or vital feature

Comments

@rithviknishad
Copy link
Member

rithviknishad commented Jan 11, 2024 •
edited
Loading

Describe the bug
404 Not found errors on district and local bodies when Advanced Filters opened.

Issue from #6889

To Reproduce
Steps to reproduce the behavior:

  1. Go to Facilities Tab
  2. Open Advanced Filters

Expected behavior
Prevent querying district and local bodies when dependent params are missing

Screenshots

image
@rithviknishad rithviknishad self-assigned this Jan 11, 2024
@github-project-automation github-project-automation bot moved this to Triage in Care Jan 11, 2024
@rithviknishad rithviknishad moved this from Triage to In Progress in Care Jan 11, 2024
rithviknishad added a commit that referenced this issue Jan 11, 2024
@rithviknishad
Fixes #7005; buggy prefetch condition for local body and district aut…
68b1afc 
…ocompletes
@rithviknishad rithviknishad mentioned this issue Jan 11, 2024
Merged
6 tasks
@rithviknishad rithviknishad added the P1 breaking issue or vital feature label Jan 11, 2024
@github-actions GitHub Actions
Copy link

⚠️ Refrain from assigning this issue to yourself if you have another P1 issue assigned that is not yet closed.
@rithviknishad kindly acknowledge this message by commenting 'Acknowledged' below.

@rithviknishad rithviknishad added bug Something isn't working and removed work-in-progress labels Jan 11, 2024
khavinshankar pushed a commit that referenced this issue Jan 11, 2024
@rithviknishad
Fixes buggy prefetch condition for local body and district autocomple…
901f619 
…tes (#7006)

* Fixes #7005; buggy prefetch condition for local body and district autocompletes

* fix not found
@github-project-automation github-project-automation bot moved this from In Progress to Done in Care Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rithviknishad rithviknishad

Labels
bug Something isn't working P1 breaking issue or vital feature
Projects
Care
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes buggy prefetch condition for local body and district autocompletes ohcnetwork/care_fe
1 participant
@rithviknishad