Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Care Icons: Add type safety for icon names #6033

Closed
rithviknishad opened this issue Aug 9, 2023 · 0 comments · Fixed by #6034
Closed

Care Icons: Add type safety for icon names #6033

rithviknishad opened this issue Aug 9, 2023 · 0 comments · Fixed by #6034
Assignees
@rithviknishad

Comments

@rithviknishad
Copy link
Member

rithviknishad commented Aug 9, 2023 •
edited
Loading

Proposed usage:

<CareIcon icon="l-hospital" className="text-lg" />

Preserve backwards compatability too:

<CareIcon className="care-l-hospital text-lg" />
@rithviknishad rithviknishad self-assigned this Aug 9, 2023
@github-project-automation github-project-automation bot moved this to Triage in Care Aug 9, 2023
rithviknishad added a commit that referenced this issue Aug 9, 2023
@rithviknishad
fixes #6033; Adds type safety for icon names
7e39537
@rithviknishad rithviknishad mentioned this issue Aug 9, 2023
Merged
6 tasks
@rithviknishad rithviknishad moved this from Triage to Review required in Care Aug 9, 2023
khavinshankar pushed a commit that referenced this issue Aug 9, 2023
@rithviknishad
🪄 Adds type safety for CareIcon names + ✨ reduced index.css size by…
dc129fb 
… 95% + Refactor string interpolated tw classes (#6034)

* refactor `CountBlock` and `PatientCategory` components

* refactor `ButtonV2` string interpolated align

* fixes #6033; Adds type safety for icon names

* refactored `Count` block

* refactor `Chip` component

* fixes #6023; remove safelist from tw config

* adds missing classes
@github-project-automation github-project-automation bot moved this from Review required to Done in Care Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rithviknishad rithviknishad

Labels
None yet
Projects
Care
Archived in project
Milestone
No milestone
1 participant
@rithviknishad