Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KASP- shifting form #5384

Closed
aparnacoronasafe opened this issue Apr 24, 2023 · 10 comments · Fixed by #5386
Closed

KASP- shifting form #5384

aparnacoronasafe opened this issue Apr 24, 2023 · 10 comments · Fixed by #5386
Assignees
Labels
P1 breaking issue or vital feature urgent

Comments

@aparnacoronasafe
Copy link

aparnacoronasafe commented Apr 24, 2023

https://care.coronasafe.in/shifting/bc8b9d9a-e28b-4e85-b66b-4de4dea1f686/update

Make "Is Karunya Arogya Suraksha Padhathi?" appear only in War-mode configuration.

This applied for the KASP field in shifting status update form as well as shifting details page (https://care.coronasafe.in/shifting/d350a891-0688-416f-8a50-a1c01a679c34)

Part of #5393

@aparnacoronasafe aparnacoronasafe added urgent P1 breaking issue or vital feature shifting labels Apr 24, 2023
@github-actions
Copy link

⚠️ Refrain from assigning this issue to yourself if you have another P1 issue assigned that is not yet closed.

@aparnacoronasafe
Copy link
Author

@rithviknishad I am so sorry. But I had a change the issue a bit. Could you please make the changes?

rithviknishad added a commit that referenced this issue Apr 24, 2023
This reverts commit 5b2f4f5.
@rithviknishad
Copy link
Member

@aparnacoronasafe I've updated the PR to include the field only when wartime is set

@gigincg
Copy link
Member

gigincg commented Apr 25, 2023

@aparnacoronasafe

  1. KASP will be disabled in our production deployments. @mathew-alex @rithviknishad Can you confirm that it is already this way
  2. When KASP (Or any other form of State Support Programme) is enabled by a state, shouldn't it be applicable in Peacetime as well?

cc: @rithviknishad

@mathew-alex
Copy link
Contributor

@aparnacoronasafe

  1. KASP will be disabled in our production deployments. @mathew-alex @rithviknishad Can you confirm that it is already this way
  2. When KASP (Or any other form of State Support Programme) is enabled by a state, shouldn't it be applicable in Peacetime as well?

cc: @rithviknishad

KASP is disabled in production deployments.

@aparnacoronasafe
Copy link
Author

@gigincg I can still see KASP in staging. hence the confusion.

If it is disabled, let it stay the same way. No change required. Could you please do the same in staging @mathew-alex so that the confusion doesnt arise.

@gigincg In our current requirements, there is no reservation in the field for any scheme. KASP even though an existing scheme acted as a reservation during COVID where the state had mentioned that so many beds must be reserved for KASP. Such a reservation system may only be required during war-time

@rithviknishad
Copy link
Member

I'll also update it such that, the field is hidden when kasp is not enabled, instead of being dependent on wartime config.

@rithviknishad
Copy link
Member

So far (as per the latest develop), the field was not hidden based on any configurations.

@khavinshankar
Copy link
Member

@rithviknishad any updates on this?

@nihal467
Copy link
Member

nihal467 commented Apr 26, 2023

@khavinshankar @rithviknishad had communicated me through slack yesterday @6 in the evening and informed the discussed changes were pushed, so I will be testing the PR now

khavinshankar pushed a commit that referenced this issue Apr 26, 2023
* fixes #5384

* Revert "fixes #5384"

This reverts commit 5b2f4f5.

* make kasp field enabled only in wartime

* kasp indpependent of wartime config

* Hide KASP reflection in Shifting Detail page

---------

Co-authored-by: Mohammed Nihal <57055998+nihal467@users.noreply.github.com>
@rithviknishad rithviknishad added this to the Shifting Module milestone Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 breaking issue or vital feature urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants