changed viewport usage to more reusable structure

ohcnetwork · Mar 5, 2025 · b1a22f5 · b1a22f5
1 parent 2cc959e
commit b1a22f5
Show file tree

Hide file tree

Showing 5 changed files with 35 additions and 4 deletions.
diff --git a/cypress/e2e/facility_spec/facility_creation.cy.ts b/cypress/e2e/facility_spec/facility_creation.cy.ts
@@ -1,6 +1,7 @@
 import { FacilityCreation } from "@/pageObject/facility/FacilityCreation";
 import { generatePhoneNumber } from "@/utils/commonUtils";
 import { generateFacilityData } from "@/utils/facilityData";
+import { viewPort } from "@/utils/viewPort";
 
 const LOCATION_HIERARCHY = {
   state: "Kerala",
@@ -14,7 +15,7 @@ describe("Facility Management", () => {
   const facilityType = "Primary Health Centre";
 
   beforeEach(() => {
-    cy.viewport(1920, 1080);
+    cy.viewport(viewPort.laptopStandard.width, viewPort.laptopStandard.height);
     cy.loginByApi("nurse");
     cy.visit("/");
   });

diff --git a/cypress/e2e/patient_spec/patient_creation.cy.ts b/cypress/e2e/patient_spec/patient_creation.cy.ts
@@ -11,6 +11,7 @@ import {
 import { PatientEncounter } from "@/pageObject/Patients/PatientEncounter";
 import { patientVerify } from "@/pageObject/Patients/PatientVerify";
 import { FacilityCreation } from "@/pageObject/facility/FacilityCreation";
+import { viewPort } from "@/utils/viewPort";
 
 const facilityCreation = new FacilityCreation();
 const patientEncounter = new PatientEncounter();
@@ -101,7 +102,7 @@ describe("Patient Management", () => {
   ];
 
   beforeEach(() => {
-    cy.viewport(1920, 1080);
+    cy.viewport(viewPort.desktop1080p.width, viewPort.desktop2k.height);
     cy.loginByApi("doctor");
     cy.visit("/");
   });

diff --git a/cypress/e2e/patient_spec/patient_details.cy.ts b/cypress/e2e/patient_spec/patient_details.cy.ts
@@ -1,14 +1,15 @@
 import { PatientDetails } from "@/pageObject/Patients/PatientDetails";
 import { PatientEncounter } from "@/pageObject/Patients/PatientEncounter";
 import { FacilityCreation } from "@/pageObject/facility/FacilityCreation";
+import { viewPort } from "@/utils/viewPort";
 
 const facilityCreation = new FacilityCreation();
 const patientEncounter = new PatientEncounter();
 const patientDetails = new PatientDetails();
 
 describe("Patient Management", () => {
   beforeEach(() => {
-    cy.viewport(1920, 1080);
+    cy.viewport(viewPort.laptopStandard.width, viewPort.laptopStandard.height);
     cy.loginByApi("devdoctor");
     cy.visit("/");
   });

diff --git a/cypress/e2e/patient_spec/patient_encounter.cy.ts b/cypress/e2e/patient_spec/patient_encounter.cy.ts
@@ -1,12 +1,13 @@
 import { PatientEncounter } from "@/pageObject/Patients/PatientEncounter";
 import { FacilityCreation } from "@/pageObject/facility/FacilityCreation";
+import { viewPort } from "@/utils/viewPort";
 
 const facilityCreation = new FacilityCreation();
 const patientEncounter = new PatientEncounter();
 
 describe("Patient Encounter Questionnaire", () => {
   beforeEach(() => {
-    cy.viewport(1920, 1080);
+    cy.viewport(viewPort.desktop1080p.width, viewPort.desktop1080p.height);
     cy.loginByApi("devnurse");
     cy.visit("/");
   });

diff --git a/cypress/utils/viewPort.ts b/cypress/utils/viewPort.ts
@@ -0,0 +1,27 @@
+export const viewPort = {
+  // Most common desktop resolution (Full HD)
+  desktop1080p: {
+    width: 1920,
+    height: 1080,
+  },
+  // Common laptop resolution (HD+)
+  laptopStandard: {
+    width: 1366,
+    height: 768,
+  },
+  // MacBook Pro 13" and similar laptops
+  laptopRetina: {
+    width: 1440,
+    height: 900,
+  },
+  // Common desktop resolution (2K)
+  desktop2k: {
+    width: 2560,
+    height: 1440,
+  },
+  // Common laptop resolution (HD)
+  laptopSmall: {
+    width: 1280,
+    height: 720,
+  },
+} as const;