suggestions from code reviews

ohcnetwork · Nov 11, 2024 · 6cda5b5 · 6cda5b5
1 parent ebb9ab9
commit 6cda5b5
Showing 1 changed file with 5 additions and 11 deletions.
diff --git a/src/components/Facility/ConsultationDetails/ConsultationNursingTab.tsx b/src/components/Facility/ConsultationDetails/ConsultationNursingTab.tsx
@@ -131,15 +131,9 @@ const NursingPlot = ({ consultationId }: ConsultationTabProps) => {
     }
   });
 
-  const dataToDisplay = data
-    .map((x) =>
-      x.nursing
-        ? x.nursing.map((f) => {
-            return { ...f, date: x.date };
-          })
-        : [],
-    )
-    .reduce((accumulator, value) => accumulator.concat(value), []);
+  const dataToDisplay = data.flatMap(
+    (x) => x.nursing?.map((f) => ({ ...f, date: x.date })) ?? [],
+  );
 
   const filterEmpty = (field: (typeof NURSING_CARE_PROCEDURES)[number]) => {
     const filtered = dataToDisplay.filter(
@@ -269,11 +263,11 @@ export default function ConsultationNursingTab(props: ConsultationTabProps) {
         breadcrumbs={false}
       />
       <div>
-        <h4>{t("routine")}</h4>
+        <h4 aria-label={t("routine")}>{t("routine")}</h4>
         <RoutineSection {...props} />
       </div>
       <div>
-        <h4>{t("nursing_care")}</h4>
+        <h4 aria-label={t("nursing_care")}>{t("nursing_care")}</h4>
         <NursingPlot {...props} />
       </div>
     </div>