Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add schema for validating meta field of assets #935

Merged
merged 5 commits into from
Jul 30, 2022

Conversation

iamsdas
Copy link
Contributor

@iamsdas iamsdas commented Jul 19, 2022

fixes: #799

@iamsdas iamsdas requested a review from a team as a code owner July 19, 2022 08:53
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2022

Codecov Report

Merging #935 (f916c4f) into master (406b615) will increase coverage by 0.00%.
The diff coverage is 51.51%.

@@           Coverage Diff           @@
##           master     #935   +/-   ##
=======================================
  Coverage   52.84%   52.85%           
=======================================
  Files         181      182    +1     
  Lines        8825     8864   +39     
=======================================
+ Hits         4664     4685   +21     
- Misses       4161     4179   +18     
Impacted Files Coverage Δ
...are/facility/models/mixins/permissions/facility.py 34.78% <20.00%> (-4.11%) ⬇️
config/authentication.py 34.17% <28.00%> (+2.74%) ⬆️
care/facility/api/viewsets/asset.py 53.02% <57.14%> (-0.13%) ⬇️
care/facility/api/viewsets/mixins/access.py 25.58% <66.66%> (+3.08%) ⬆️
care/facility/models/asset.py 95.52% <66.66%> (-2.87%) ⬇️
care/facility/api/viewsets/patient_consultation.py 63.26% <100.00%> (+0.76%) ⬆️
care/facility/models/json_schema/asset.py 100.00% <100.00%> (ø)
care/facility/models/patient_consultation.py 96.55% <100.00%> (ø)
care/users/models.py 73.94% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2a0677...f916c4f. Read the comment docs.

@iamsdas
Copy link
Contributor Author

iamsdas commented Jul 25, 2022

We will be needing another migration to handle the existing invalid meta objects. Before I work on that, can someone confirm the correctness of this implementation?

@iamsdas iamsdas requested a review from vigneshhari July 25, 2022 11:13
@vigneshhari
Copy link
Member

ignore the existing values since we cant really do anything in those cases.

@vigneshhari vigneshhari merged commit 223dd7e into ohcnetwork:master Jul 30, 2022
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@iamsdas iamsdas deleted the schema branch July 30, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants