Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed malfunction in facility creation #931

Merged
merged 4 commits into from
Jul 18, 2022

Conversation

aeswibon
Copy link
Member

Updates

@aeswibon aeswibon requested a review from a team as a code owner July 16, 2022 19:57
@aeswibon aeswibon added the P1 High priority; urgent label Jul 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2022

Codecov Report

Merging #931 (fe8075a) into master (9730efd) will decrease coverage by 1.43%.
The diff coverage is 15.38%.

@@            Coverage Diff             @@
##           master     #931      +/-   ##
==========================================
- Coverage   54.23%   52.80%   -1.44%     
==========================================
  Files         181      181              
  Lines        8824     8839      +15     
==========================================
- Hits         4786     4667     -119     
- Misses       4038     4172     +134     
Impacted Files Coverage Δ
...are/facility/models/mixins/permissions/facility.py 32.65% <15.38%> (-9.02%) ⬇️
...e/utils/serializer/phonenumber_ispossible_field.py 50.00% <0.00%> (-43.75%) ⬇️
config/serializers.py 36.84% <0.00%> (-31.58%) ⬇️
care/audit_log/middleware.py 47.36% <0.00%> (-22.81%) ⬇️
care/users/models.py 73.94% <0.00%> (-16.20%) ⬇️
care/facility/models/mixins/permissions/base.py 45.00% <0.00%> (-15.00%) ⬇️
care/users/api/viewsets/users.py 43.50% <0.00%> (-12.34%) ⬇️
care/facility/api/viewsets/facility.py 58.10% <0.00%> (-12.17%) ⬇️
care/users/api/serializers/user.py 56.77% <0.00%> (-9.33%) ⬇️
care/facility/models/patient.py 88.09% <0.00%> (-6.75%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9730efd...fe8075a. Read the comment docs.

Copy link
Member

@vigneshhari vigneshhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested

care/facility/models/mixins/permissions/facility.py Outdated Show resolved Hide resolved
care/facility/models/mixins/permissions/facility.py Outdated Show resolved Hide resolved
care/facility/models/mixins/permissions/facility.py Outdated Show resolved Hide resolved
care/facility/models/mixins/permissions/facility.py Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vigneshhari vigneshhari merged commit f2a0677 into ohcnetwork:master Jul 18, 2022
@aeswibon aeswibon deleted the issue#930 branch July 19, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority; urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facility Creation: Malfunction
3 participants