Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for middleware authentication #923

Merged
merged 4 commits into from
Jul 18, 2022

Conversation

sainak
Copy link
Member

@sainak sainak commented Jul 12, 2022

  • improved error messages for invalid tokens
  • added documentation
  • add middleware authentication automatically when using Assetaccessmixin

@sainak sainak requested a review from a team as a code owner July 12, 2022 18:41
@sainak sainak requested review from gigincg and vigneshhari July 12, 2022 18:41
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2022

Codecov Report

Merging #923 (af0fb29) into master (59b80de) will decrease coverage by 1.36%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #923      +/-   ##
==========================================
- Coverage   54.23%   52.86%   -1.37%     
==========================================
  Files         181      181              
  Lines        8823     8839      +16     
==========================================
- Hits         4785     4673     -112     
- Misses       4038     4166     +128     
Impacted Files Coverage Δ
config/authentication.py 34.17% <28.00%> (+1.32%) ⬆️
care/facility/api/viewsets/mixins/access.py 25.58% <66.66%> (+3.08%) ⬆️
care/facility/api/viewsets/patient_consultation.py 63.26% <100.00%> (+0.76%) ⬆️
care/facility/models/patient_consultation.py 96.55% <100.00%> (ø)
...e/utils/serializer/phonenumber_ispossible_field.py 50.00% <0.00%> (-43.75%) ⬇️
config/serializers.py 36.84% <0.00%> (-31.58%) ⬇️
care/audit_log/middleware.py 47.36% <0.00%> (-22.81%) ⬇️
care/users/models.py 73.94% <0.00%> (-16.13%) ⬇️
care/facility/models/mixins/permissions/base.py 45.00% <0.00%> (-15.00%) ⬇️
care/users/api/viewsets/users.py 43.50% <0.00%> (-12.34%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59b80de...af0fb29. Read the comment docs.

@vigneshhari
Copy link
Member

Do you think that the commits are somehow messed up? i can see changes that were already made in the previous PR

@sainak sainak changed the title fix middleware authentication Improvements to middleware authentication Jul 17, 2022
@sainak sainak changed the title Improvements to middleware authentication Improvements for middleware authentication Jul 17, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vigneshhari vigneshhari merged commit 5874f32 into master Jul 18, 2022
@sainak sainak deleted the sainAk/middleware-integration branch September 6, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants