update asset integration actions #909
Conversation
iamsdas
commented
Jul 4, 2022
- minor bug fixes
- sort out misplaced actions between hl7 and onvif.
care/utils/assetintegration/base.py
Outdated
| @@ -14,7 +14,7 @@ def handle_action(self, action): | |||
| pass | |||
|
|
|||
| def get_url(self, endpoint): | |||
| return "http://{}/{}".format(self.middleware_hostname, endpoint) | |||
| return "https://{}/{}".format(self.middleware_hostname, endpoint) | |||
There was a problem hiding this comment.
Are you sure this would work in a local env?
There was a problem hiding this comment.
Maybe not, but using http only was giving me unexpected errors while testing with the dev camera.
There was a problem hiding this comment.
move it to an env variable then, with the default set to https
There was a problem hiding this comment.
Instead of an environment variable, I added the variable to the asset metadata with it defaulting to https as it makes more sense to have the connection type set per asset.
There was a problem hiding this comment.
ideally, we would not want any data to be sent over non HTTPS in production (especially medical data)
There was a problem hiding this comment.
Added a check to prevent sending insecure requests in production mode.