Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable ratelimit in local dev server #630

Merged
merged 2 commits into from
Oct 12, 2021
Merged

Disable ratelimit in local dev server #630

merged 2 commits into from
Oct 12, 2021

Conversation

shaileshaanand
Copy link
Contributor

@shaileshaanand shaileshaanand commented Oct 5, 2021 •
edited
Loading

closes #613

This PR adds a check to disable ratelimit in dev server.

It checks if DISABLE_RATELIMIT is True in settings.py to disble ratelimit in ratelimit.py

@shaileshaanand shaileshaanand requested a review from a team as a code owner October 5, 2021 12:25
@shaileshaanand shaileshaanand force-pushed the disable-local-ratelimit branch from 196968e to e617f6f Compare October 6, 2021 05:23
@shaileshaanand shaileshaanand self-assigned this Oct 6, 2021
gigincg
gigincg requested changes Oct 11, 2021
View reviewed changes
Copy link
Member

@gigincg gigincg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add the common DISABLE_RATELIMIT = False to base.py

@gigincg gigincg removed the done label Oct 11, 2021
@shaileshaanand shaileshaanand force-pushed the disable-local-ratelimit branch from ca261b5 to b4b98cf Compare October 11, 2021 16:00
@gigincg gigincg merged commit 604d7cc into ohcnetwork:master Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gigincg gigincg gigincg approved these changes

Assignees

@shaileshaanand shaileshaanand

Labels
done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable rate_limit in Local and Dev mode.
2 participants
@shaileshaanand @gigincg