Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filters for current_location and registered_name in DeviceFilters #2873

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

Rishith25
Copy link
Contributor

@Rishith25 Rishith25 commented Feb 27, 2025

Proposed Changes

Associated Issue ohcnetwork/care_fe#10831

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins

Summary by CodeRabbit

  • New Features
    • Added a filter to search devices by their current location.
    • Added a filter for case-insensitive, partial matching on device registered names.

@Rishith25 Rishith25 requested a review from a team as a code owner February 27, 2025 04:29
Copy link
Contributor

coderabbitai bot commented Feb 27, 2025

📝 Walkthrough

Walkthrough

This pull request updates the DeviceFilters class in the device viewset module by adding two new filter fields. The current_location filter uses a UUID filter mapped to current_location__external_id, and the registered_name filter facilitates case-insensitive containment lookups. The existing current_encounter filter remains unchanged.

Changes

File Change Summary
care/emr/.../device.py Added current_location (UUID filter mapped to current_location__external_id) and registered_name (case-insensitive character filter) to DeviceFilters

Suggested reviewers

  • vigneshhari

Poem

In the code’s quiet maze, new filters unfold,
Two fresh paths in DeviceFilters, so neatly told.
Current location and registered name join the fray,
While the old one stubbornly stays its way.
A subtle upgrade—if only all changes were this clear!
🌟 Happy coding in your refined frontier!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4a16a09 and a9c36d7.

📒 Files selected for processing (1)
  • care/emr/api/viewsets/device.py (1 hunks)
🔇 Additional comments (1)
care/emr/api/viewsets/device.py (1)

49-50: Good job on adding these filters, they look properly implemented.

The filters for current_location and registered_name follow the right pattern and will enhance the filtering capabilities of the DeviceViewSet. The use of UUIDFilter for location and CharFilter with icontains for the name makes perfect sense for these field types.

I'm sure you've already thought about testing these new filters, right? It would be nice to have tests verifying they work as expected, especially for edge cases like partial name matching.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vigneshhari vigneshhari merged commit 566324d into ohcnetwork:develop Feb 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for filter by name and location for Device
2 participants