Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switched to ubuntu-24.04-arm runners #2742

Merged
merged 1 commit into from
Jan 19, 2025
+10 −10
Merged

switched to ubuntu-24.04-arm runners #2742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
build:
needs: test
name: Build & Push to container registries
runs-on: ubuntu-latest
runs-on: ubuntu-24.04-arm
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

The runner label format appears to be incorrect.

The label ubuntu-24.04-arm doesn't follow GitHub's runner label format. According to the GitHub blog post referenced in the PR, you might want to use ubuntu-24.04 with runs-on: ["ubuntu-24.04", "arm64"] instead.

Apply this change to all jobs:

-    runs-on: ubuntu-24.04-arm
+    runs-on: ["ubuntu-24.04", "arm64"]

Also applies to: 121-121, 131-131

🧰 Tools
🪛 actionlint (1.7.4)

38-38: label "ubuntu-24.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)

steps:
- uses: actions/checkout@v4

Expand Down Expand Up @@ -118,7 +118,7 @@ jobs:
needs: build
if: startsWith(github.event.ref, 'refs/tags/v')
name: Notify release
runs-on: ubuntu-latest
runs-on: ubuntu-24.04-arm
steps:
- name: Notify release
run: |
Expand All @@ -128,7 +128,7 @@ jobs:
needs: build
if: github.ref == 'refs/heads/develop'
name: Deploy to ECS API Egov
runs-on: ubuntu-latest
runs-on: ubuntu-24.04-arm
environment:
name: Staging-egov
url: https://careapi.ohc.network
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@ jobs:
build-docs:
if: github.repository == 'ohcnetwork/care'
name: Build docs
runs-on: ubuntu-latest
runs-on: ubuntu-24.04-arm
steps:
- uses: actions/checkout@v4

- uses: actions/setup-python@v5
with:
python-version: "3.13"
cache: 'pipenv'
cache: "pipenv"

- name: Install pipenv
run: pip install pipenv
Expand All @@ -46,7 +46,7 @@ jobs:
deploy-docs:
if: github.repository == 'ohcnetwork/care' && github.ref == 'refs/heads/develop'
name: Deploy docs
runs-on: ubuntu-latest
runs-on: ubuntu-24.04-arm
needs: build-docs
permissions:
contents: write
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/issue-automation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
jobs:
issue_opened_and_reopened:
name: issue_opened_and_reopened
runs-on: ubuntu-latest
runs-on: ubuntu-24.04-arm
if: github.repository == 'ohcnetwork/care' && github.event_name == 'issues' && github.event.action == 'opened' || github.event.action == 'reopened'
steps:
- name: 'Move issue to "Triage"'
Expand All @@ -21,7 +21,7 @@ jobs:
status_value: "Triage"
issue_closed:
name: issue_closed
runs-on: ubuntu-latest
runs-on: ubuntu-24.04-arm
if: github.repository == 'ohcnetwork/care' && github.event_name == 'issues' && github.event.action == 'closed'
steps:
- name: 'Moved issue to "Done"'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/linter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:

jobs:
lint:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04-arm
steps:
- uses: actions/checkout@v4
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reusable-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:

jobs:
test:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04-arm
steps:
- uses: actions/checkout@v4

Expand Down
Loading